fix(bundle-size): don't import react-select twice #2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice 👍 I think this is related #328 |
|
Thanks @chrfritsch for the reference - I was looking for an issue about it, but not hard enough I guess |
MilesRomney
pushed a commit
to MilesRomney/netlify-cms
that referenced
this pull request
Nov 18, 2019
nathankitchen
pushed a commit
to nathankitchen/netlify-cms-backend-azure
that referenced
this pull request
Feb 24, 2020
vladdu
pushed a commit
to vladdu/netlify-cms
that referenced
this pull request
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While waiting for the gatsby repo to clone 😪 I analyzed the bundle size and noticed
react-selectwas imported twice.Before:
After:
