Update AuthenticationPage.js #2134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the login button's negative margin to prevent obscuring the logo. Adjusted the custom logos height and width to scale according to the file up to a predefined max-width and max-height so that it can align to the center. #2133
|
Preview proposed changes to the CMS demo site in the link below: Built with commit 9a1dc0f |
|
No idea what I am doing. Please look at this carefully 😛 |
barthc
reviewed
Mar 1, 2019
|
Preview proposed changes to netlifycms.org in the link below: Built with commit 9a1dc0f |
|
Just checking in on this - does everything look gucci now? The incorrectly aligned logo on the login page has been making a poor first impression to Netlify CMS. |
|
@tomrutgers can you test and approve this PR please, it's a first time contributor. |
|
I might be missing something but when I'm testing it, the changes do not seem to fix the problem when using larger images:
|
|
Can you see why the max-height is not being applied to the HTML.COM image? |
|
@adamcnaglich It's not applied to the image, it's applied to its wrapper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the login button's negative margin to prevent obscuring the logo. Adjusted the custom logos height and width to scale according to the file up to a predefined max-width and max-height so that it can align to the center.
fixes #2133
Summary
Removed the login button's negative margin to prevent obscuring the logo. Adjusted the custom logos height and width to scale according to the file up to a predefined max-width and max-height so that it can align to the center.
Test plan
