Skip to content

Conversation

@donatas
Copy link

@donatas donatas commented Jun 13, 2018

Our log collector expects the output to be of some format (across systems, that write logs) and now the only thing I can't control is the namespace, prepended to each line.

It's enabled by default, passing environment variable allows hiding it.

PR contains tests that cover default behavior (namespace + log) and the new feature.

@donatas donatas changed the title Add option to not hide namespace Add option to hide namespace in logs Jun 13, 2018
@donatas
Copy link
Author

donatas commented Jun 13, 2018

@TooTallNate please review

@coveralls
Copy link

Coverage Status

Coverage increased (+7.06%) to 80.838% when pulling d790954 on donatas:master into 22f9932 on visionmedia:master.

@coveralls
Copy link

coveralls commented Jun 13, 2018

Coverage Status

Coverage increased (+7.06%) to 80.838% when pulling 5bbfcb0 on donatas:master into 22f9932 on visionmedia:master.

@donatas
Copy link
Author

donatas commented Jun 13, 2018

@thebigredgeek @nkolban

@Qix-
Copy link
Member

Qix- commented Jun 20, 2018

Hi there - I'm 👎 personally with adding yet another env var. Could you weigh in on #582?

@Qix- Qix- added discussion This issue is requesting comments and discussion feature This proposes or provides a feature or enhancement change-minor This proposes or provides a change that requires a minor release awaiting-response This issue or pull request is awaiting a user's response labels Jun 20, 2018
@Qix-
Copy link
Member

Qix- commented Dec 13, 2018

Closing in favor of #582.

@Qix- Qix- closed this Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-response This issue or pull request is awaiting a user's response change-minor This proposes or provides a change that requires a minor release discussion This issue is requesting comments and discussion feature This proposes or provides a feature or enhancement

Development

Successfully merging this pull request may close these issues.

3 participants