-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBZ-7244 Event Hubs topic routing #57
base: main
Are you sure you want to change the base?
DBZ-7244 Event Hubs topic routing #57
Conversation
Seems like debezium#51 introduced a potential regression, where if the sink is configured with a custom producer, it is not wrapped in a BatchManager and batchManager will be null when handleBatch is invoked.
Thinking about adding an integration test, but would have to delve deeper into how tests are setup first, and how to add changes from another source table (to test topic routing for two different tables). Seems like the second commit fixes an earlier potential regression. I'm not sure how I would configure a |
@aleksandervalle Overall LGTM, thanks. I've one proposal, instead of adding a new config option I think it is ok just to modify the existing one to be able to process the list instead of a single value. It will be backward compatible, the code will be simplified and no new option is needed. |
I removed the new optional config, and we're now using the required |
Maybe the documentation should be updated to reflect these changes? Idea for new description: Specifies the name(s) of the Event Hub(s) to be used. You can provide a single hub name or a comma-separated list of hub names without any whitespace. When multiple hub names are specified, Debezium will direct the change events to the corresponding Event Hub based on the event's destination. If the destination of a change event does not match any of the listed hub names, the first hub in the list will be used as the default destination. Usage Example: In this example, |
https://issues.redhat.com/browse/DBZ-7244