DBZ-3124 Add ENUM column type support for Vitess 9.0.0#20
Merged
keweishang merged 2 commits intoFeb 19, 2021
Conversation
keweishang
commented
Feb 18, 2021
Member
gunnarmorling
left a comment
gunnarmorling
left a comment
There was a problem hiding this comment.
LGTM; some small suggestions inline.
Member
|
@ani-sha, just seeing that the JIRA-key-less commit message didn't trigger a build failure here. Could you look into setting up the commit message job for this (and potentially other) repo? Thx! |
Member
|
@keweishang, sorry, just noticed one more thing is missing for the docs update in core: the data type table still lists enums as unsupported. |
Member
Author
@gunnarmorling, sorry I missed that. I just created a PR for updating the documentation - data type table lists enums as supported: |
Member
Author
|
@ani-sha I'll push an amend-commit (a.k.a. |
keweishang
force-pushed
the
DBZ-3124-add-enum-support
branch
2 times, most recently
from
4569ecc to
0b3e58d
Compare
keweishang
force-pushed
the
DBZ-3124-add-enum-support
branch
from
0b3e58d to
9e9f48e
Compare
gunnarmorling
approved these changes
Feb 19, 2021
Member
gunnarmorling
left a comment
gunnarmorling
left a comment
There was a problem hiding this comment.
LGTM now, thx! Can you merge yourself and resolve the issue once CI has passed? Thanks a lot!
Member
Author
|
Sure, I'll merge the PR and resolve the issue once CI has passed. |
maxenglander
added a commit
to planetscale/debezium-connector-planetscale
that referenced
this pull request
Oct 16, 2024
Enable support for enums during vstream copy phase.
There are two reasons that the connector does not handle `enum` for PSDB branches.
1. The upstream debezium-connector-vitess simply does not support
`enum` during the VStream copy phase. It tries to cast the row value
to an integer, but the value is a string. It seems support for
`enum` landed in 2021
debezium#20, and
support for snapshots (VStream Copy) landed in 2022
debezium#112,
without taking the former into account. This is easily fixed by
finding finding the index of the string
value in the list of values obtained from `column_type` during the
schema discovery phase at the beginning of the VStream.
2. However, this isn't working on some PSDB branches which don't have
the fix vitessio/vitess#13045 for this bug
vitessio/vitess#12981. Fixable by
backporting the bugfix or upgrading those branches.
Signed-off-by: Max Englander <max@planetscale.com>
maxenglander
added a commit
to planetscale/debezium-connector-planetscale
that referenced
this pull request
Oct 16, 2024
Enable support for enums during vstream copy phase.
There are two reasons that the connector does not handle `enum` for PSDB branches.
1. The upstream debezium-connector-vitess simply does not support
`enum` during the VStream copy phase. It tries to cast the row value
to an integer, but the value is a string. It seems support for
`enum` landed in 2021
debezium#20, and
support for snapshots (VStream Copy) landed in 2022
debezium#112,
without taking the former into account. This is easily fixed by
finding finding the index of the string
value in the list of values obtained from `column_type` during the
schema discovery phase at the beginning of the VStream.
2. However, this isn't working on some PSDB branches which don't have
the fix vitessio/vitess#13045 for this bug
vitessio/vitess#12981. Fixable by
backporting the bugfix or upgrading those branches.
Signed-off-by: Max Englander <max@planetscale.com>
maxenglander
added a commit
to planetscale/debezium-connector-planetscale
that referenced
this pull request
Oct 18, 2024
Enable support for enums during vstream copy phase.
There are two reasons that the connector does not handle `enum` for PSDB branches.
1. The upstream debezium-connector-vitess simply does not support
`enum` during the VStream copy phase. It tries to cast the row value
to an integer, but the value is a string. It seems support for
`enum` landed in 2021
debezium#20, and
support for snapshots (VStream Copy) landed in 2022
debezium#112,
without taking the former into account. This is easily fixed by
finding finding the index of the string
value in the list of values obtained from `column_type` during the
schema discovery phase at the beginning of the VStream.
2. However, this isn't working on some PSDB branches which don't have
the fix vitessio/vitess#13045 for this bug
vitessio/vitess#12981. Fixable by
backporting the bugfix or upgrading those branches.
Signed-off-by: Max Englander <max@planetscale.com>
maxenglander
added a commit
to planetscale/debezium-connector-planetscale
that referenced
this pull request
Oct 18, 2024
Enable support for enums during vstream copy phase.
There are two reasons that the connector does not handle `enum` for PSDB branches.
1. The upstream debezium-connector-vitess simply does not support
`enum` during the VStream copy phase. It tries to cast the row value
to an integer, but the value is a string. It seems support for
`enum` landed in 2021
debezium#20, and
support for snapshots (VStream Copy) landed in 2022
debezium#112,
without taking the former into account. This is easily fixed by
finding finding the index of the string
value in the list of values obtained from `column_type` during the
schema discovery phase at the beginning of the VStream.
2. However, this isn't working on some PSDB branches which don't have
the fix vitessio/vitess#13045 for this bug
vitessio/vitess#12981. Fixable by
backporting the bugfix or upgrading those branches.
Signed-off-by: Max Englander <max@planetscale.com>
maxenglander
added a commit
to planetscale/debezium-connector-planetscale
that referenced
this pull request
Oct 18, 2024
Enable support for enums during vstream copy phase.
There are two reasons that the connector does not handle `enum` for PSDB branches.
1. The upstream debezium-connector-vitess simply does not support
`enum` during the VStream copy phase. It tries to cast the row value
to an integer, but the value is a string. It seems support for
`enum` landed in 2021
debezium#20, and
support for snapshots (VStream Copy) landed in 2022
debezium#112,
without taking the former into account. This is easily fixed by
finding finding the index of the string
value in the list of values obtained from `column_type` during the
schema discovery phase at the beginning of the VStream.
2. However, this isn't working on some PSDB branches which don't have
the fix vitessio/vitess#13045 for this bug
vitessio/vitess#12981. Fixable by
backporting the bugfix or upgrading those branches.
Signed-off-by: Max Englander <max@planetscale.com>
maxenglander
added a commit
to planetscale/debezium-connector-planetscale
that referenced
this pull request
Oct 21, 2024
Enable support for enums during vstream copy phase.
There are two reasons that the connector does not handle `enum` for PSDB branches.
1. The upstream debezium-connector-vitess simply does not support
`enum` during the VStream copy phase. It tries to cast the row value
to an integer, but the value is a string. It seems support for
`enum` landed in 2021
debezium#20, and
support for snapshots (VStream Copy) landed in 2022
debezium#112,
without taking the former into account. This is easily fixed by
finding finding the index of the string
value in the list of values obtained from `column_type` during the
schema discovery phase at the beginning of the VStream.
2. However, this isn't working on some PSDB branches which don't have
the fix vitessio/vitess#13045 for this bug
vitessio/vitess#12981. Fixable by
backporting the bugfix or upgrading those branches.
Signed-off-by: Max Englander <max@planetscale.com>
maxenglander
added a commit
to planetscale/debezium-connector-planetscale
that referenced
this pull request
Oct 23, 2024
Enable support for enums during vstream copy phase.
There are two reasons that the connector does not handle `enum` for PSDB branches.
1. The upstream debezium-connector-vitess simply does not support
`enum` during the VStream copy phase. It tries to cast the row value
to an integer, but the value is a string. It seems support for
`enum` landed in 2021
debezium#20, and
support for snapshots (VStream Copy) landed in 2022
debezium#112,
without taking the former into account. This is easily fixed by
finding finding the index of the string
value in the list of values obtained from `column_type` during the
schema discovery phase at the beginning of the VStream.
2. However, this isn't working on some PSDB branches which don't have
the fix vitessio/vitess#13045 for this bug
vitessio/vitess#12981. Fixable by
backporting the bugfix or upgrading those branches.
Signed-off-by: Max Englander <max@planetscale.com>
maxenglander
added a commit
to planetscale/debezium-connector-planetscale
that referenced
this pull request
Oct 25, 2024
Enable support for enums during vstream copy phase.
There are two reasons that the connector does not handle `enum` for PSDB branches.
1. The upstream debezium-connector-vitess simply does not support
`enum` during the VStream copy phase. It tries to cast the row value
to an integer, but the value is a string. It seems support for
`enum` landed in 2021
debezium#20, and
support for snapshots (VStream Copy) landed in 2022
debezium#112,
without taking the former into account. This is easily fixed by
finding finding the index of the string
value in the list of values obtained from `column_type` during the
schema discovery phase at the beginning of the VStream.
2. However, this isn't working on some PSDB branches which don't have
the fix vitessio/vitess#13045 for this bug
vitessio/vitess#12981. Fixable by
backporting the bugfix or upgrading those branches.
Signed-off-by: Max Englander <max@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/DBZ-3124
Related PRs: