Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options and Settings menus miss checkboxes in macos #140

Closed
vlsi opened this issue Jul 2, 2018 · 0 comments · Fixed by #141
Closed

Options and Settings menus miss checkboxes in macos #140

vlsi opened this issue Jul 2, 2018 · 0 comments · Fixed by #141

Comments

@vlsi
Copy link
Contributor

vlsi commented Jul 2, 2018

macos 10.13.5, Java 1.8.0u152

Here's the default command line for the app launcher:

/Library/Java/JavaVirtualMachines/jdk1.8.0_152.jdk/Contents/Home/bin/java\
 -cp .:/Applications/Luyten.app/Contents/Resources/Java/luyten-0.5.3.jar\
 -splash:/Applications/Luyten.app/Contents/Resources/\
 -Xdock:icon=/Applications/Luyten.app/Contents/Resources/luyten.icns\
 -Xdock:name=Luyten\
 -Dapple.awt.antialiasing=true\
 -Dapple.laf.useScreenMenuBar=true\
 us.deathmarine.luyten.LuytenOsx

It turns out, apple.laf.useScreenMenuBar=true defeats JCheckBoxes in the menu items.

Is there a reason Luyten uses JCheckBox instead of JCheckBoxMenuItem?
vlsi added a commit to vlsi/Luyten that referenced this issue Jul 2, 2018
@vlsi
deathmarine#140 make checkbox entries in Operation/Settings menus vis…
79aa40e 
…ible in macOS

JCheckBox was not shown when running with -Dapple.laf.useScreenMenuBar=true,
so converted JCheckBox to JCheckBoxMenuItem
vlsi added a commit to vlsi/Luyten that referenced this issue Jul 2, 2018
@vlsi
deathmarine#140 make checkbox entries in Operation/Settings menus vis…
7f07ccf 
…ible in macOS

JCheckBox was not shown when running with -Dapple.laf.useScreenMenuBar=true,
so converted JCheckBox to JCheckBoxMenuItem

fixes deathmarine#140
@vlsi vlsi mentioned this issue Jul 2, 2018
Merged
deathmarine added a commit that referenced this issue Aug 7, 2018
@deathmarine
Merge pull request #141 from vlsi/menu_checkbox
7405efa 
#140 make checkbox entries in Operation/Settings menus visible in macOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#140 make checkbox entries in Operation/Settings menus visible in macOS vlsi/Luyten
1 participant
@vlsi