resolved issues when testing extension on Chrome Version 133.0.6943.1…#368
Open
lj020326 wants to merge 1 commit intodeathau:v4-from-scratchfrom
Open
resolved issues when testing extension on Chrome Version 133.0.6943.1…#368lj020326 wants to merge 1 commit intodeathau:v4-from-scratchfrom
lj020326 wants to merge 1 commit intodeathau:v4-from-scratchfrom
Conversation
…43 (Official Build) (x86_64) running on MacOS 15.3.1 (24D70) modified: welcome.js modified: manifest.json modified: .gitignore
lj020326
force-pushed
the
v4-from-scratch
branch
from
d767ec1 to
9a0ca23
Compare
|
@deathau - I expect you are busy but it would be nice to get this one as the extension does not load at all now if you have a moment please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolved issues when testing extension on Chrome Version 133.0.6943.143 (Official Build) (x86_64) running on MacOS 15.3.1 (24D70).
Upon loading the extension successfully after updating the manifest.json, the "Uncaught ReferenceError: browser is not defined" exception was thrown from sidepanel/welcome.js. This appears to be resolved with the updated welcome.js.
modified: welcome.js
modified: manifest.json