Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relative links have wrong url #1

Closed
deathau opened this issue May 14, 2020 · 0 comments
Closed

relative links have wrong url #1

deathau opened this issue May 14, 2020 · 0 comments
Assignees
@deathau
Labels
bug Something isn't working

Comments

@deathau
Copy link
Owner

deathau commented May 14, 2020

For example, clipping https://notes.andymatuschak.org/About_these_notes there are many relative links (for example/z3SjnvsB5aR2ddsycyXofbYR7fCxo7RmKW2be).
When converting them to markdown, they come out with the extension as the domain (e.g. moz-extension://112865e2-6d18-4214-8783-df5c914cce79/z3SjnvsB5aR2ddsycyXofbYR7fCxo7RmKW2be)
@deathau deathau added the bug Something isn't working label May 14, 2020
@deathau deathau self-assigned this May 14, 2020
LucSPI added a commit to LucSPI/MarkDownLoad that referenced this issue Feb 12, 2024
@LucSPI
Add a base element to the DOM with current URL
729e3c5 
This makes the DOM parse with a correct base URI instead of the extension's base URI, which fixes deathau/markdownload#1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deathau deathau

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@deathau