Update edown 0.8.4 #141
Open
Update edown 0.8.4 #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mopp
commented
Jun 7, 2022
doc/prometheus_collector.md
Outdated
| @@ -80,7 +80,7 @@ Example (simplified `prometheus_vm_memory_collector`): | |||
|
|
|||
|
|
|||
| <pre><code> | |||
| collect_mf_callback() = fun((<a href="prometheus_model.md#type-MetricFamily">prometheus_model:'MetricFamily'()</a>) -> any()) | |||
| collect_mf_callback() = fun((<a href="http://www.erlang.org/edoc/doc/prometheus/doc/prometheus_model.html#type-MetricFamily">prometheus_model:'MetricFamily'()</a>) -> any()) | |||
There was a problem hiding this comment.
Hmm, I checked the diff of the edown but these changes may not cause these changes.
uwiger/edown@0.8.1...0.8.4
@deadtrickster So I've expected that you do git restore these wrong links on your local afterrebar3 edoc.
Should I replace the wrong links manually? Or do you know any workaround?
There was a problem hiding this comment.
I found the doc_path option.
See https://github.com/uwiger/edown/tree/master/doc#links-to-other-edown-generated-docs
However, it does not work as I expected because the application name and the repository name are different... 😢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I've used Erlang/OTP 24.2 and I found
rebar3 edoccauses the error below because I tried to fix the documents.See also #142
What I did
I just update the down version and regenerate the document.