Image fixes #1
Merged
Image fixes #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename Image.Metadata to Image.DockerImageMetadata to avoid serialization conflict with Kubernetes Metadata type. Update Image and ImageRepositoryMapping to use Name instead of ID.
Author
|
@smarterclayton fyi |
Author
|
What I did to test this was:
|
|
We should make the registry pull if not present normally I think
|
deads2k
added a commit
that referenced
this pull request
Nov 20, 2014
deads2k
pushed a commit
that referenced
this pull request
Dec 19, 2014
Update bindata to match an updated dependency
deads2k
pushed a commit
that referenced
this pull request
Jan 26, 2015
Separate asset bind and asset public addr
deads2k
pushed a commit
that referenced
this pull request
Jan 28, 2015
Cast string to UID to fix rebase type change
deads2k
pushed a commit
that referenced
this pull request
Jan 29, 2015
Fix bindata.go for the less partials split
deads2k
pushed a commit
that referenced
this pull request
Jul 6, 2016
README enhancements, specified requirements
deads2k
pushed a commit
that referenced
this pull request
Aug 16, 2016
Changes createLocalGitDirecory to s2i version
deads2k
pushed a commit
that referenced
this pull request
Jun 16, 2017
…service-catalog/' changes from c91fecb..568a7b9 568a7b9 origin build: add origin tooling 1bfff53 instance never provisioned should just delete (openshift#891) 1ae26db Adding a fake broker server (openshift#928) 6403076 docs: fix quoting issue, clarify naming in auth.md (openshift#931) 8ac0775 Merge branch 'pr/927' 02af952 Merge branch 'pr/876' 2aa84f9 add Jenkins badge to README 0c08788 Brokers must have at least one service (openshift#930) cbfa39b Add PodPreset support (openshift#917) 0d9b810 refactor Jenkins GitHub status postback to work on non-PR commits (openshift#916) 066159d Converting the AuthSecret field to a union AuthInfo type (openshift#877) 203af5c Add leader election namespace configuration (openshift#920) 5831502 Add example JSON schema to controller unit tests (openshift#918) b78ab99 Fix usage of finalizers (openshift#894) d3d29f0 Enable pprof in controller-manager (openshift#896) f4233a0 Correct parameter schema support (openshift#912) 05c6f00 bump image tags from v0.0.8 to v0.0.9 (openshift#910) 97d278a Add support for OSB parameter schemas (openshift#822) 3e4120e Fix nil dereference panic on request timeout (openshift#906) d8c7494 Add feature gate for audit options in helm chart (openshift#904) 89ce1cd Decompose controller unit tests (openshift#899) a1e83b2 Add e2e for walkthrough (openshift#832) 4679685 Add support for audit log options (openshift#897) 262a94f Do not allow updates to an object if asynchronous operation is in progress (openshift#853) 7295dad Validate that a ServiceClass must have at least one plan (openshift#879) 9db9fa4 Decompose controller.go (openshift#893) c3ea9bd Nits in our types (openshift#854) 1d8280a bump tags from v0.0.7 to v0.0.8 (openshift#892) 5e6925d Clean up the OSB client (openshift#888) fe6aee9 cleaning up logs and adding more log detail (openshift#874) f41516f Detect if a TPR update represents a soft delete (openshift#836) 9ce99f3 Add functions on Makefile for build and tag REVERT: c91fecb Merge pull request #1 from jpeeler/origin-build REVERT: 55ccf3d origin build: add _output to .gitignore REVERT: 8352e14 origin build: make build-go and build-cross work REVERT: d969641 origin build: modify hard coded path REVERT: 30000cc origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: 568a7b9dbdc4fdd1fabffdd52af030ec73124b89
deads2k
pushed a commit
that referenced
this pull request
Sep 15, 2017
Building images from RPM takes quite a bit of time, so add service catalog to the local image build list. A prerequisite for this task is to have the service catalog binaries compiled, which is done with #1: 1) cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog/hack/build-go.sh 2) hack/build-local-images service-catalog The first script uses the origin tooling to build in the same way as the RPMs are built. Note that a new "enable_default" key has been added to the image_config and set to False for service catalog so that it is not built unless directly specified (as indicated in #2).
deads2k
pushed a commit
that referenced
this pull request
Feb 9, 2018
Automatic merge from submit-queue. CLI: add support for deployments in oc status @smarterclayton this is a long overdue... current state: ``` $ oc status In project My Project (myproject) on server https://127.0.0.1:8443 svc/ruby-deploy - 172.30.174.234:8080 deployment/ruby-deploy deploys istag/ruby-deploy:latest <- bc/ruby-deploy source builds https://github.com/openshift/ruby-ex.git on istag/ruby-22-centos7:latest build #1 failed 5 hours ago - bbb6701: Merge pull request #18 from durandom/master (Ben Parees <bparees@users.noreply.github.com>) deployment #2 running for 4 hours - 0/1 pods (warning: 53 restarts) deployment #1 deployed 5 hours ago ``` TODO: - [x] Add rollouts similar to deployment configs - [x] Fix unit tests / Add unit tests - [x] Deal with HPA
deads2k
pushed a commit
that referenced
this pull request
Mar 20, 2018
…rvices-w-same-selector Automatic merge from submit-queue (batch tested with PRs 18953, 18992). group services w same selectors in `oc status` Fixes openshift#7503 **Before** ```bash $ oc status In project My Project (myproject) on server https://127.0.0.1:8443 svc/foo - foo.com dc/myapp deploys istag/myapp:latest <- bc/myapp source builds https://github.com/juanvallejo/myapp on openshift/nodejs:8 deployment #1 deployed 7 minutes ago - 1 pod svc/bar - 172.30.75.107:8080 dc/myapp deploys istag/myapp:latest <- bc/myapp source builds https://github.com/juanvallejo/myapp on openshift/nodejs:8 deployment #1 deployed 7 minutes ago - 1 pod ... ``` **After** ```bash $ oc status In project My Project (myproject) on server https://127.0.0.1:8443 svc/bar - 172.30.75.107:8080 svc/foo - foo.com dc/myapp deploys istag/myapp:latest <- bc/myapp source builds https://github.com/juanvallejo/myapp on openshift/nodejs:8 deployment #1 deployed 7 hours ago - 1 pod ... ``` cc @soltysh @deads2k
deads2k
pushed a commit
that referenced
this pull request
Jul 9, 2024
…717157796269-fbabcock update upgrade window check and exception messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename Image.Metadata to Image.DockerImageMetadata to avoid
serialization conflict with Kubernetes Metadata type.
Update Image and ImageRepositoryMapping to use Name instead of ID.
openshift/docker-registry-extensions#1 depends on this.