-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rustdoc integration #105
Comments
This will be useful for rustdoc (deadlinks#105).
Hmm, unfortunately some of the licenses in lol_html's dependencies are not MIT or Apache:
|
WIP implementation: https://github.com/jyn514/rust/tree/linkcheck |
Note that is blocked on rust-lang/rust#80527, but I expect figuring out the dependencies will take long enough that will be merged before I have to worry about it. |
I guess as a last resort I could make deadlinks generic over the parser and slot in https://github.com/rust-lang/rust/blob/94e6ea9fc97845b336067bffb3d103780474f6f5/src/tools/linkchecker/main.rs#L406 somehow, but that really seems like a hack, parsing HTML with regex is never a good idea. |
Oh I'm being silly - html5ever meets all the licenses. So I can make deadlinks generic over the parser and slot in HTML5ever for rust-lang/rust. |
Finally got a response about licensing, other tools already use the licenses so it shouldn't be a problem: https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/Is.20there.20an.20approved.20HTML.20parser.3F/near/312418703 Mark did suggest that this doesn't necessarily need to be part of rustdoc, and that a |
It would be great to add deadlinks to rustdoc itself! That would increase discoverability a ton, and I expect it would uncover a bunch more bugs in rustdoc too. It would also allow getting rid of the linkchecker in the rust repo.
As a bonus, rustdoc does know how it generates the links, so this might allow fixing #14 (comment) at the same time.
The text was updated successfully, but these errors were encountered: