-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warning on GLib >=2.79.2 #981
Conversation
Your change isn't compatible with GNOME versions older than 46. ddterm But you likely can make it work for all GNOME versions using https://gjs-docs.gnome.org/gjs/overrides.md#gi-require |
I have been able to backport it to all systems using ESM on my own branch, but I might have stumbled on a ESM translator edge case being unable to translate |
There's also sed preprocessing step to solve issues like that: gnome-shell-extension-ddterm/ddterm/shell/notifications.js Lines 143 to 151 in bfcdf69
You should be able to use legacy imports between |
I didn't feel sure about adding a lint exception, but I guessed it would be a better solution than adding dead code to the non-ESM build or duplicating the preprocessed code. Feedback is welcomed. |
No description provided.