-
-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use TARGETARCH instead of TARGETPLATFORM in user Dockerfiles #6711
Conversation
Can confirm in manual testing that this worked. |
Download the artifacts for this pull request:
See Testing a PR. |
@rfay, I also want to point out that At that time I checked sqlite3.45.1 - it worked, and I forgot about it until today.
ddev/containers/ddev-webserver/Dockerfile Lines 70 to 75 in 924ad6f
It will add +1250 KBytes to the image:
Let me know what you think about it. |
Now that we sorted out what we were chasing, I think TARGETARCH might have been (He had an ancient Colima with an ancient docker server version in it, that apparently passed TARGETPLATFORM=linux/arm64/v8) As far as I can tell, TARGETPLATFORM in this context should only have been linux/amd64 or linux/arm64. That doesn't mean that this PR is less correct. It's more elegant for sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should go with this because it's simpler and more elegant.
The Issue
From Drupal Slack https://drupal.slack.com/archives/C5TQRQZRR/p1731341586120089
Looking at that URL, I suspect that the Docker build engine is using
arm64/v8
as the target platform, which makes sense, but that maybe makes the URL of the SQLite.deb
wrong.If I remove the
/v8
from that URL in my browser, it actually tries to download something.Is there a way I can override the
TARGETPLATFORM
build argument in.ddev/config.yaml
to force it to bearm64
, as a workaround?From https://ddev.readthedocs.io/en/stable/users/extend/customizing-images/#adding-extra-dockerfiles-for-webimage-and-dbimage, it looks like maybe the workaround that installs SQLite should be using
TARGETARCH
instead ofTARGETPLATFORM
.How This PR Solves The Issue
Uses
TARGETARCH
in the user Dockerfile, this change is also important for the newly added 'install_php_extensions.sh'Manual Testing Instructions
Should pass the tests.
Automated Testing Overview
Release/Deployment Notes