Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make latest tag same hash, push latest for most #6622

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented Oct 16, 2024

The Issue

When we were reviewing the results of

today, Stas pointed out that

  • latest didn't have the correct matching hash
  • ddev-dbserver didn't get latest tag at all

How This PR Solves The Issue

I couldn't help but work on it a bit, so here it is.

This should not go into DDEV v1.23.5, and testing was done against ddevhq org

Manual Testing Instructions

Use the web UI to push images.

@rfay rfay marked this pull request as ready for review October 17, 2024 02:59
@rfay rfay requested a review from a team as a code owner October 17, 2024 02:59
@rfay rfay requested a review from stasadev October 17, 2024 16:30
Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rfay rfay merged commit 788720e into ddev:master Oct 17, 2024
18 checks passed
@rfay rfay deleted the 20241016_rfay_push_fixes branch October 17, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants