Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add mysqladmin to web container for mysql, fixes #6355 #6360

Merged
merged 2 commits into from
Jul 1, 2024
Merged

fix: add mysqladmin to web container for mysql, fixes #6355 #6360

merged 2 commits into from
Jul 1, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented Jun 29, 2024

The Issue

When installing custom-built mysql clients in ddev-webserver we only added mysql and mysqldump, but people also use mysqladmin

How This PR Solves The Issue

Add mysqladmin

Manual Testing Instructions

With a mysql:8.0 or mysql:5.7 project use ddev ssh and mysqladmin or ddev exec mysqladmin

Automated Testing Overview

Added check to verify in both the container test and TestWebserverDBClient

@github-actions github-actions bot added bugfix dependencies Pull requests that update a dependency file labels Jun 29, 2024
@github-actions GitHub Actions
Copy link

Download the artifacts for this pull request:

See Testing a PR.

Open in Gitpod

Open in GitHub Codespaces

@rfay rfay marked this pull request as ready for review June 30, 2024 21:45
@rfay rfay requested a review from a team as a code owner June 30, 2024 21:45
@rfay rfay mentioned this pull request Jun 30, 2024
Closed
4 tasks
@stasadev stasadev self-requested a review July 1, 2024 11:20
@stasadev stasadev removed their assignment Jul 1, 2024
stasadev
stasadev approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, everything looks good:

$ mysqladmin
mysqladmin  Ver 8.0.36 for Linux on x86_64 (Source distribution)

$ mysqladmin
mysqladmin  Ver 8.42 Distrib 5.7.44, for Linux on x86_64

@rfay rfay merged commit cdd62b6 into ddev:master Jul 1, 2024
27 checks passed
@rfay rfay deleted the 20240629_rfay_mysqladmin_in_web branch July 1, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stasadev stasadev stasadev approved these changes

Assignees
No one assigned
Labels
bugfix dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfay @stasadev