Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TYPO3 no longer has typo3cms command, update other out-of-date #6211

Merged
merged 2 commits into from
May 20, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented May 18, 2024

The Issue

Important information for longtime users
The CLI binary typo3cms was removed with version 8.0.0 and is replaced by the TYPO3 CLI binary typo3. Commands that were called e.g. typo3cms database:updateschema before, must now be called with typo3 database:updateschema.

  • A number of references to AdditionalConfiguration.php were updated to the current v12+ "additional.php" and also "settings.php"

Manual Testing Instructions

  • Use the TYPO3 quickstart to install
  • Also use the TYPO3 docs quickstart - the GUI version is easier as it respects the additional.php

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

Copy link

@mandrasch
Copy link
Collaborator

Curious question: Should we test if install guides for older versions like v11.5 and v12 still work with this change? (backwards-compatibility)

https://docs.typo3.org/m/typo3/tutorial-getting-started/11.5/en-us/Installation/TutorialDdev.html
https://docs.typo3.org/m/typo3/tutorial-getting-started/12.4/en-us/Installation/TutorialDdev.html

EOL roadmap: https://typo3.org/cms/roadmap

@rfay
Copy link
Member Author

rfay commented May 19, 2024

Should we test if install guides for older versions like v11.5 and v12 still work with this change?

Our general approach to TYPO3 (and now really Drupal as well) has mostly been just to explicitly support the current LTS.

In general, people who understand what they're doing can make settings files or do GUI installs as need be without any trouble. The extra DDEV settings are really just to be helpful and get people started fast. But sometimes they get dependent and think it's magic :)

@mandrasch
Copy link
Collaborator

mandrasch commented May 20, 2024

Thanks very much for insights, didn't know about the LTS part! 💡

The link in manual testing instructions is wrong if I see it correctly - it refers to latest version (v13)
https://docs.typo3.org/m/typo3/tutorial-getting-started/main/en-us/Installation/Install.html#install

Should be this for current LTS v12 https://docs.typo3.org/m/typo3/tutorial-getting-started/12.4/en-us/Installation/Install.html

On the "install via DDEV" page they also display a warning on branch main docs:

Screenshot_20240520_092919_Chrome.jpg

Just a personal note, guess there will be no breaking changes for "older" versions:

I experienced it in web agencies that projects were not updated immediately due to budget reasons / big changes needed. Starter templates also remained on "older" versions for some time - so not breaking the official TYPO3 ddev install guides for one or two versions before current LTS would be good for developer experience imho. Especially if they invest time for their own DDEV install docs for each major version.
EOL roadmap for supported versions could be a good indicator imho (if maintainable). But extended support is also often paid as far as I know. Guess that's no real news, just wanted to let you know. :)

@rfay
Copy link
Member Author

rfay commented May 20, 2024

DDEV provides so very much support for older things, with old database and PHP versions. We just don't have the bandwidth to try to keep things up for many, many versions. So we started the LTS strategy with TYPO3 and have mostly done that, although as you know DDEV has some code to detect older TYPO3, and now also the drupal type which can handle a variety. It's always a balancing act.

@rfay rfay marked this pull request as ready for review May 20, 2024 20:32
@rfay rfay requested review from a team as code owners May 20, 2024 20:32
@rfay rfay merged commit 926722b into ddev:master May 20, 2024
25 checks passed
@rfay rfay deleted the 20240518_typo3_new_config branch May 20, 2024 20:32
jonesrussell pushed a commit to jonesrussell/ddev that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants