Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix markdownlint problems by using different headers instead of different links #6198

Merged
merged 2 commits into from
May 16, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented May 16, 2024

This reverts commit 41f38c7.

See discussion in #6197

I had to do a --no-verify to push this because I have pre-push checks enabled

@rfay rfay requested a review from a team as a code owner May 16, 2024 17:44
@stasadev
Copy link
Member

I don't see a way how to fix it quickly.

Perhaps we can simply not use such anchors, but change them:

-## Maintaining `ddev-dbserver` MySQL 5.7 & 8.0 ARM64 Images
+## Maintaining `ddev-dbserver` MySQL 5.7 and 8.0 ARM64 Images
-## Fork / Clone the DDEV Repository
+## Fork or Clone the DDEV Repository

@rfay
Copy link
Member Author

rfay commented May 16, 2024

That's a good solution.

@rfay rfay requested a review from stasadev May 16, 2024 18:04
@rfay
Copy link
Member Author

rfay commented May 16, 2024

OK, see what you think of this @stasadev

@rfay rfay changed the title docs: REVERT Fix a couple of broken link fragments (#6197) [skip ci] docs: Fix markdownlint problems by using different headers instead of different links May 16, 2024
Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, thank you!

I like that it is settled now.

@rfay rfay merged commit 887c75e into ddev:master May 16, 2024
8 of 9 checks passed
@rfay rfay deleted the 20240516_revert_links branch May 16, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants