Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change php default version to 8.2, fixes #5767 #5835

Merged
merged 5 commits into from
Feb 15, 2024
Merged

feat: change php default version to 8.2, fixes #5767 #5835

merged 5 commits into from
Feb 15, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented Feb 13, 2024

The Issue

How This PR Solves The Issue

Change the default everywhere

Manual Testing Instructions

Try it out. ddev config --auto in an empty directory should get a default of 8.2
Start it up. ddev php --version should have 8.2

this won't be testable until I push new images. I'll wait to push new images until

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@github-actions github-actions bot added dependencies Pull requests that update a dependency file enhancement labels Feb 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2024 •
edited
Loading

Download the artifacts for this pull request:

See Testing a PR

@rfay rfay mentioned this pull request Feb 14, 2024
Merged
@rfay rfay marked this pull request as ready for review February 14, 2024 21:48
@rfay rfay requested review from a team as code owners February 14, 2024 21:48
@rfay rfay requested a review from stasadev February 14, 2024 21:48
stasadev
stasadev approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
FYI: the default PHP version in the docs is still 8.1:

ddev/docs/content/users/configuration/config.md

Line 414 in df3bfed

| :octicons-file-directory-16: project | `8.1` | Can be `5.6`, `7.0`, `7.1`, `7.2`, `7.3`, `7.4`, `8.0`, `8.1`, `8.2`, or `8.3`.

ddev/docs/content/users/extend/customization-extendibility.md

Line 12 in df3bfed

The project's `.ddev/config.yaml` file defines the PHP version to use. The [`php_version`](../configuration/config.md#php_version) can be changed to `5.6`, `7.0`, `7.1`, `7.2`, `7.3`, `7.4`, `8.0`, `8.1`, `8.2`, or `8.3`. The current default is `8.1`.

@rfay
Copy link
Member Author

rfay commented Feb 15, 2024

Thanks @stasadev , good eye. Not sure how I missed those, fixed in e1e1044

@rfay rfay merged commit efa8cea into ddev:master Feb 15, 2024
9 checks passed
@rfay rfay deleted the 20240213_php_8.2_default branch February 15, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stasadev stasadev stasadev approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfay @stasadev