feat: support TablePlus application located in setapp directory (#5815) #5816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
See Testing a PR |
rfay
approved these changes
Feb 10, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
TablePlus is not only available via download from the vendor website but is also part of the SetApp subscription model. In that case, the application is installed in a different directory and thus the
ddev tablepluscommand doesn't work.How This PR Solves The Issue
This PR checks of tableplus is located in the setapp directory. If not, the default path is used.
Default path is
/Applications/TablePlus.appSetApp path is
/Applications/Setapp/TablePlus.appManual Testing Instructions
ddev tableplusworks for both, normal users and SetApp users.