Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cpus limits in docker-compose.minio.yaml #43

Conversation

dstorozhuk
Copy link
Contributor

The Issue

Trying to start ddev for the project in GitHub actions, and got this error:

Error response from daemon: Range of CPUs is from 0.01 to 2.00, as there are only 2 CPUs available'

How This PR Solves The Issue

Reduces the required number of CPUs to 2.0

Manual Testing Instructions

N/A

Automated Testing Overview

N/A

Related Issue Link(s)

Is there are some requirements for the runner

Release/Deployment Notes

N/A

@rfay rfay changed the title Update docker-compose.minio.yaml Change cpus limits in docker-compose.minio.yaml Feb 17, 2025
@rfay
Copy link
Member

rfay commented Feb 17, 2025

@seebeen is there even a reason for this limits key in the first place?

@rfay rfay requested a review from seebeen February 17, 2025 17:23
@seebeen
Copy link
Collaborator

seebeen commented Feb 18, 2025

MinIO is resource heavy. I've had a couple of situation where it took 90% of the CPU in test scenario.
CPU limit curtails it and enforces a sane limit for dev env.

@rfay
Copy link
Member

rfay commented Feb 18, 2025

In that case, you're probably fine with this PR, true? It makes lots of sense in most environments.

@seebeen seebeen added this pull request to the merge queue Feb 21, 2025
Merged via the queue into ddev:master with commit 1862f59 Feb 21, 2025
3 checks passed
Copy link

🎉 This PR is included in version 2.0.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rfay
Copy link
Member

rfay commented Feb 21, 2025

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants