fix: don't try to release not-bound ports (ddev#6612)

ddev-test · Oct 14, 2024 · aeb5ee0 · aeb5ee0
1 parent d74fbf7
commit aeb5ee0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/pkg/ddevapp/router.go b/pkg/ddevapp/router.go
@@ -283,7 +283,9 @@ func GetRouterBoundPorts() ([]uint16, error) {
 	}
 
 	for _, p := range r.Ports {
-		boundPorts = append(boundPorts, p.PublicPort)
+		if p.PublicPort != 0 {
+			boundPorts = append(boundPorts, p.PublicPort)
+		}
 	}
 	return boundPorts, nil
 }

diff --git a/pkg/netutil/netutil.go b/pkg/netutil/netutil.go
@@ -40,7 +40,7 @@ func IsPortActive(port string) bool {
 		}
 	}
 	// Otherwise, hmm, something else happened. It's not a fatal but can be reported.
-	util.Warning("Unable to properly check port status: %v", oe)
+	util.Warning("Unable to properly check port status for %s:%s: err=%v", dockerIP, port, err)
 	return false
 }