Skip to content

Commit

Permalink
fix: not-included PHP version should work with webimage_extra_packages (
Browse files Browse the repository at this point in the history
  • Loading branch information
rfay authored Nov 11, 2024
1 parent bc33850 commit a340e88
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions pkg/ddevapp/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -1280,6 +1280,7 @@ fi`, app.Database.Version, psqlVersion) + "\n\n"
contents = contents + fmt.Sprintf(`
### DDEV-injected folders permission fix
RUN chmod 777 /run/php /var/log
RUN mkdir -p /tmp/xhprof && chmod -R ugo+w /etc/php /var/lib/php /tmp/xhprof
`)
}

Expand Down
4 changes: 4 additions & 0 deletions pkg/ddevapp/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -861,6 +861,10 @@ func TestPHPConfig(t *testing.T) {

for _, v := range phpKeys {
app.PHPVersion = v
// TODO: Remove this exclusion when redis is available for PHP 8.4
if app.PHPVersion != nodeps.PHP84 {
app.WebImageExtraPackages = []string{"php" + app.PHPVersion + "-redis"}
}
err = app.Restart()
require.NoError(t, err)

Expand Down

0 comments on commit a340e88

Please sign in to comment.