-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: try using scikit-build-core #43
Conversation
Signed-off-by: Henry Schreiner <[email protected]>
Thanks so much for this. I'm going to merge it with some changes to support looking at |
Ping me if you have any problems or questions! |
Also, if you are able to support Stable ABI eventually, it's: #define Py_LIMITED_API 0x030b00f0 And [tool.scikit-build]
wheel.py-api = "cp311" This will build per-version wheels up to 3.11, then a single binary that works on all future version in 3.11. Cibuildwheel will only test this on 3.12, and not try to rebuild. |
Thanks, I think I will likely switch to using a Any ideas on the Windows build? https://github.com/dcwatson/deflate/actions/runs/8995764433/job/24711221117#step:3:236
This is my first foray into CMake, so forgive me if I'm missing something obvious 😄 |
Ahh, thought Windows ran in tests. I see now it's just ubuntu. I think it's likely because I was trying something; if you add |
Ah, also, you are right, |
Hah, I'm pretty sure I found that in a comment from you on some other random repo. |
Trying out scikit-build-core.