Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: try using scikit-build-core #43

Merged
merged 2 commits into from
May 8, 2024

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented May 7, 2024

Trying out scikit-build-core.

Signed-off-by: Henry Schreiner <[email protected]>
@dcwatson
Copy link
Owner

dcwatson commented May 8, 2024

Thanks so much for this. I'm going to merge it with some changes to support looking at LIBDEFLATE_PREFIX for system-installed versions.

@dcwatson dcwatson merged commit 1dddeec into dcwatson:main May 8, 2024
6 checks passed
@henryiii
Copy link
Contributor Author

henryiii commented May 8, 2024

Ping me if you have any problems or questions!

@henryiii
Copy link
Contributor Author

henryiii commented May 8, 2024

Also, if you are able to support Stable ABI eventually, it's:

#define Py_LIMITED_API 0x030b00f0

And

[tool.scikit-build]
wheel.py-api = "cp311"

This will build per-version wheels up to 3.11, then a single binary that works on all future version in 3.11. Cibuildwheel will only test this on 3.12, and not try to rebuild.

@dcwatson
Copy link
Owner

dcwatson commented May 8, 2024

Thanks, I think I will likely switch to using a memoryview, and the rest will probably come easy 🤞

Any ideas on the Windows build? https://github.com/dcwatson/deflate/actions/runs/8995764433/job/24711221117#step:3:236

      Could NOT find Python (missing: Python_LIBRARIES Development.Module) (found
      version "3.8.10")

This is my first foray into CMake, so forgive me if I'm missing something obvious 😄

@henryiii
Copy link
Contributor Author

henryiii commented May 8, 2024

Ahh, thought Windows ran in tests. I see now it's just ubuntu. I think it's likely because I was trying something; if you add Interpreter to the COMPONENTS list, I think it will be fine. I can check on my fork now, though, to be sure.

@henryiii
Copy link
Contributor Author

henryiii commented May 8, 2024

Ah, also, you are right, Development.Module is better than Development. I meant to do that (that's why I set 3.18 as the minimum instead of 3.15), but seems to have forgotten about it when actually writing the line.

@dcwatson
Copy link
Owner

dcwatson commented May 8, 2024

Hah, I'm pretty sure I found that in a comment from you on some other random repo.

@henryiii henryiii deleted the henryiii/chore/backend branch May 27, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants