Run through rustfmt, update to Rust 2018, rework to use Arc instead of lifetimes. #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinmehall
reviewed
Mar 29, 2019
Responding to comments from @kevinmehall.
jeamland
changed the title
|
I had some issues with the current API, but using this branch fixed it and seem to work fine. |
|
What is the current state of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes, this is probably too many changes in one PR but if you're interested I'm willing to do the work in splitting them out.
323bce9 just runs all the code through rustfmt.
dd035dc removes a couple of
mutdeclarations the linter was complaining about.b4cee90 updates everything to Rust 2018.
fc27e0c is the big one: it removes the explicit lifetime declarations and uses Rc instead to maintain pointers without needing consumers of the library to explicitly declare lifetimes too.
All tests still pass.