Switch ELB port 80 from HTTP to TCP mode. #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about Azure? |
|
LGTM. I was initially concerned about the changes to InternalMasterLoadBalancer, since it may introduce subtle issues for internal services which poll adminrouter... But since the health checks are still explicitly HTTP, polling services won't see a difference. @brndnmtthws how confident are you in this from a testing perspective? |
|
@lingmann I've tested this, and we're using TCP on Azure already anyway, so it will be transparent to the user. |
|
Also rebased on master. |
|
🚢 |
Merged
d2iq-mergebot
pushed a commit
that referenced
this pull request
Dec 5, 2019
DCOS_OSS-5725: atomic file creation for paths.json, bugfixed the json encoding to UTF-8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @spahl