Fix Docker perm issue on Linux #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamarni
force-pushed
the
perm-issue-linux
branch
from
584a8d0 to
cbc6f0b
Compare
When running `make` using Docker (`NO_DOCKER` is not exported), the `make plugin` command then fails on Linux because of a permission issue. The binary is owned by root thus the plugin ZIP cannot be created. This changes the Docker command to run as the current user, it also sets the HOME directory to `/tmp` as `/root` wouldn't be writable but is still needed for Go cache files.
bamarni
force-pushed
the
perm-issue-linux
branch
from
cbc6f0b to
c30d902
Compare
janisz
approved these changes
Sep 3, 2019
makkes
approved these changes
Sep 3, 2019
br-lewis
approved these changes
Sep 3, 2019
makkes
approved these changes
Sep 3, 2019
janisz
added a commit
to janisz/dcos-cli
that referenced
this pull request
Aug 19, 2020
This changes the Docker command to run as the current user, it also sets the HOME directory to /tmp as /root wouldn't be writable but is still needed for Go cache files. Refs: dcos/dcos-core-cli#347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
makeusing Docker (NO_DOCKERis not exported), themake plugincommand then fails on Linux because of a permission issue.The binary is owned by root thus the plugin ZIP cannot be created.
This changes the Docker command to run as the current user, it also sets
the HOME directory to
/tmpas/rootwouldn't be writable but isstill needed for Go cache files.