Add mirroring role for example-cnf #25
Conversation
|
check dallas ocp-4.7-vanilla example-cnf |
|
|
||
| - name: "Apply ImageContentSourcePolicy" | ||
| k8s: | ||
| src: "{{ mrn_manifest_dir }}/imageContentSourcePolicy.yaml" |
There was a problem hiding this comment.
Note that adding a source policy will reboot all the nodes. It results in increased CI duration. In order to avoid reboot for this (to reduce the CI durtation), the top-level mirror entry is added as part of the installation itself.
There was a problem hiding this comment.
Just learned that the machine config operator will only reboot nodes on OCP-4.6 and below (openshift/machine-config-operator#2259), that is 4.5 and 4.6.
Are you suggesting to add quay.io/rh-nfv-int to the installation to avoid one extra reboot on those OCP versions that need it? If so, I agree that it will speed-up the time, the only caveat I see is that during installation time we don't know yet if example-cnf will be executed next or not 🤔. Also, any other image not in that registry will also be added through the ImageContentSourcePolicy, for example dpdk.
There was a problem hiding this comment.
Just learned that the machine config operator will only reboot nodes on OCP-4.6 and below (openshift/machine-config-operator#2259), that is 4.5 and 4.6.
Good to know about this improvement. I still believe machine config will apply the configs on all nodes (without reboot) and restart crio. Do you know whether nodes will go to NOT READY and then READY (faster)? How much time does it take (in 4.7)?
Are you suggesting to add quay.io/rh-nfv-int to the installation to avoid one extra reboot on those OCP versions that need it? If so, I agree that it will speed-up the time, the only caveat I see is that during installation time we don't know yet if example-cnf will be executed next or not thinking. Also, any other image not in that registry will also be added through the ImageContentSourcePolicy, for example dpdk.
Having a mirror entry at the install time for unused images is not going to affect the deployment. All example cnf images are within the quay.io/rh-nfv-int repo, except testpmd image, for which there are already entries as it is from the redhat registry.
There was a problem hiding this comment.
I still believe machine config will apply the configs on all nodes (without reboot) and restart crio.
Correct, it still needs to restart the service if the entries are not yet available in the registries.conf
Do you know whether nodes will go to NOT READY and then READY (faster)? How much time does it take (in 4.7)?
Haven't measured in 4.7 but the last successful job https://www.distributed-ci.io/jobs/40c6303c-c6b7-4bdc-a78f-137b29380333/jobStates#95e71f77-2fb1-4b43-b185-f78565f2c225:file286 shows only a few seconds when the nodes are checked.
Having a mirror entry at the install time for unused images is not going to affect the deployment.
Do you know where I can add that entry so we can save an extra reboot/restart I think is in the file under the setting: disconnected_registry_mirrors_file (in dci-openshift-agent) but any pointer is appreciated.
There was a problem hiding this comment.
I'm including the org namespace (rh-nfv-int) in the installer trust bundles https://github.com/dci-labs/service-configs/pull/12 this should speed up when applying the ImageContentSourcePolicies in here
There was a problem hiding this comment.
Haven't measured in 4.7 but the last successful job https://www.distributed-ci.io/jobs/40c6303c-c6b7-4bdc-a78f-137b29380333/jobStates#95e71f77-2fb1-4b43-b185-f78565f2c225:file286 shows only a few seconds when the nodes are checked.
Thanks, it's good to know.
|
check dallas ocp-4.7-vanilla example-cnf |
|
check dallas ocp-4.7-vanilla example-cnf |
|
Unable to find cluster5 pipeline |
|
SUCCESS from #25 |
|
Unable to find cluster5 pipeline |
|
SUCCESS from #25 |
|
check dallas ocp-4.7-vanilla example-cnf |
| {{ mrn_mirror_index_image }} | ||
| {{ mrn_local_registry }} | ||
|
|
||
| - name: "Apply ImageContentSourcePolicy" |
There was a problem hiding this comment.
Is this still required after the mirror is added?
There was a problem hiding this comment.
If the config has been already added it will not render a new machineConfig and the following steps will go really quick.
I think it would be good to leave it just in case someone else is running it without that entry in the ImageContentSourcePolicy already.
|
check dallas ocp-4.7-vanilla example-cnf |
betoredhat
left a comment
betoredhat
left a comment
There was a problem hiding this comment.
Nice mirroring role, LGTM
|
I'll go ahead and merge, we can rollback or modify if it's necessary. |
Depends-on: https://github.com/dci-labs/inventories/pull/31