-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make onOutsidePress
optional
#271
Comments
onOutsideClick
optionalonOutsidePress
optional
You can handle the "disabled" behaviour in your |
Yes, and? It is not convenient
…On Fri, Feb 16, 2024, 22:46 Mike Boutin ***@***.***> wrote:
You can handle the "disabled" behaviour in your onOutsidePress function
—
Reply to this email directly, view it on GitHub
<#271 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AR5SO7TCT3ZJZJQLVXUZWBTYT6ZQFAVCNFSM6AAAAAA4SPL7ZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBZGIZDENBVHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@gavrilikhin-d yes and? Feel free to do a pull request |
Honestly, I'm getting some negative vibes from you from the start of our conversation. That is why my reply could be perceived as rude. I don't care for your library strongly enough to do a pull request. If you don't want to improve API for the others, why should I convince you and take some extra effort? Just a rhetorical question, not an offence. Have a nice day! |
It's not my library. You can just appreciate others work and help them to improve it. "Start of our converstation", there were no conversation. You needed a way to disable it, I proposed something that actually works. Your answer is the negative vibe here and I just reflected your negativity to you and answered it in the most common way: "If you want something done right, you have to do it yourself!" Have a nice day |
Setting
onOutsidePress={undefined}
should be the same as settingdisabled
The text was updated successfully, but these errors were encountered: