Mixins take3 #1762
Merged
Mixins take3 #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please ignore it for now. The build fails for compat code. |
|
I had been using Node 11. One strange issue, occasionally, the grunt build will succeed (the rollup part), even if it has an error (which would fail in CI environments). If I run The first step, I am switching to Node 12 on my local machine. |
|
Ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1703, type definitions are now generated.
After considering multiple approaches, settling to this one. It involved one interface each that describes what each of the three Mixins expects. In addition, all members of the mixin themselves need to be public.
We will need to exclude the private members during typdoc configuration.