-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for the fs_context function #75
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dburgener
requested changes
Dec 1, 2022
matt-sheets
force-pushed
the
masheets/fs_context
branch
from
December 2, 2022 17:11
296e920
to
086348d
Compare
dburgener
reviewed
Dec 7, 2022
dburgener
reviewed
Dec 7, 2022
matt-sheets
force-pushed
the
masheets/fs_context
branch
2 times, most recently
from
December 12, 2022 16:46
b19ad28
to
dde0a99
Compare
dburgener
reviewed
Dec 13, 2022
matt-sheets
force-pushed
the
masheets/fs_context
branch
from
December 15, 2022 21:23
fd953eb
to
4965ca1
Compare
dburgener
reviewed
Jan 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't do a totally comprehensive review. Just a few comments.
dburgener
reviewed
Jan 5, 2023
dburgener
reviewed
Jan 5, 2023
dburgener
reviewed
Jan 5, 2023
dburgener
reviewed
Jan 5, 2023
dburgener
reviewed
Jan 5, 2023
dburgener
reviewed
Jan 5, 2023
dburgener
reviewed
Jan 5, 2023
dburgener
reviewed
Jan 5, 2023
matt-sheets
force-pushed
the
masheets/fs_context
branch
2 times, most recently
from
January 12, 2023 16:03
72cd9b4
to
c34c727
Compare
This function will cover both fsuse and genfscon.
* Converted FileSystemContextRule to try_from * Added more error checking * formatting and typo fixes
matt-sheets
force-pushed
the
masheets/fs_context
branch
from
January 13, 2023 21:20
c34c727
to
d8a5897
Compare
dburgener
reviewed
Jan 13, 2023
dburgener
reviewed
Jan 13, 2023
dburgener
reviewed
Jan 13, 2023
dburgener
reviewed
Jan 18, 2023
dburgener
reviewed
Jan 18, 2023
dburgener
reviewed
Jan 18, 2023
dburgener
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user can now use "fs_context" to implement fsuse and genfscon rules in policy.