Teach CascadeStrings about files #219
Comments
dburgener
added a commit
that referenced
this issue
May 9, 2023
The actual validation and error reporting part here is straightforward. Most of the complexity of this commit comes from tracking the file the alias is declared in through to the error site. That is both complex, and will likely hurt performance due to file clone()s in a non-error path. The good news is that we'll likely get all the performance back, and reduce code complexity once we implement #219. When we do that, it's probably worth revisiting this commit to make sure everything is cleaned up appropriately and we're not tracking files around for no reason.
dburgener
added a commit
that referenced
this issue
May 9, 2023
The actual validation and error reporting part here is straightforward. Most of the complexity of this commit comes from tracking the file the alias is declared in through to the error site. That is both complex, and will likely hurt performance due to file clone()s in a non-error path. The good news is that we'll likely get all the performance back, and reduce code complexity once we implement #219. When we do that, it's probably worth revisiting this commit to make sure everything is cleaned up appropriately and we're not tracking files around for no reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now that CompileError uses SimpleFiles under the hood, we can just pass around file_ids instead of file references, which makes this feasible. It will simplify error handling, and eliminate the class of errors where a file and range can be mismatched.
The text was updated successfully, but these errors were encountered: