-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify privatelink can't connect across cloud providers #6371
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -0,0 +1 @@ | |||
PrivateLink endpoints can't connect across cloud providers. For a PrivateLink connection to work, both dbt Cloud and the server (like {props.type}) must be hosted on the same cloud provider. For example, AWS PrivateLink can’t connect to resources hosted on Azure, and Azure PrivateLink can’t connect to resources hosted on AWS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to mention what alternatives to consider if users are in this situation? e.g. do they need to consider alternatives like a VPN or any other solution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding additional options would just confuse people more. I think this is pretty good. I might tweak the last sentence a bit to something like:
"For example, dbt Cloud hosted on AWS cannot connect via PrivateLink to services hosted on Azure, and dbt Cloud hosted on Azure can’t connect via Private Link to services hosted on AWS."
Small note that PrivateLink on AWS doesn't have a space, but on Azure it does (Private Link).
Can you also change the first sentence in the opening paragraph of https://docs-getdbt-com-git-cross-cloud-privatelink-dbt-labs.vercel.app/docs/cloud/secure/about-privatelink? (quoted below). Maybe something more generic would be good, like just removing "AWS" the link to AWS 🤷 or get more specific by also calling out Azure.
|
great feedback @awalther52 @dhaworth, thank you! have folded in your feedback and will get this merged! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you! I setup PLs on the dbt side, and when I read our docs I was confused about this cross cloud point. Now I think it's clear what we support and what we don't. Really appreciate the quick change here!
oh that's so cool and great to know! thank you for confirming and for your huge help! |
this pr adds clarification that privatelink cannot connect across cloud providers. this was raised in internal slack thread and confirmed by support and engineers.
used a snippet to convey this across 4 pages.
🚀 Deployment available! Here are the direct links to the updated files: