Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify privatelink can't connect across cloud providers #6371

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

@mirnawong1 mirnawong1 requested a review from a team as a code owner October 28, 2024 12:11
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 28, 2024 3:03pm

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Oct 28, 2024
@@ -0,0 +1 @@
PrivateLink endpoints can't connect across cloud providers. For a PrivateLink connection to work, both dbt Cloud and the server (like {props.type}) must be hosted on the same cloud provider. For example, AWS PrivateLink can’t connect to resources hosted on Azure, and Azure PrivateLink can’t connect to resources hosted on AWS.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to mention what alternatives to consider if users are in this situation? e.g. do they need to consider alternatives like a VPN or any other solution?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding additional options would just confuse people more. I think this is pretty good. I might tweak the last sentence a bit to something like:

"For example, dbt Cloud hosted on AWS cannot connect via PrivateLink to services hosted on Azure, and dbt Cloud hosted on Azure can’t connect via Private Link to services hosted on AWS."

Small note that PrivateLink on AWS doesn't have a space, but on Azure it does (Private Link).

@awalther52
Copy link

Can you also change the first sentence in the opening paragraph of https://docs-getdbt-com-git-cross-cloud-privatelink-dbt-labs.vercel.app/docs/cloud/secure/about-privatelink? (quoted below). Maybe something more generic would be good, like just removing "AWS" the link to AWS 🤷 or get more specific by also calling out Azure.

PrivateLink enables a private connection from any dbt Cloud Multi-Tenant environment to your data platform hosted on AWS using AWS PrivateLink technology.

@mirnawong1
Copy link
Contributor Author

great feedback @awalther52 @dhaworth, thank you! have folded in your feedback and will get this merged!

Copy link

@awalther52 awalther52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! I setup PLs on the dbt side, and when I read our docs I was confused about this cross cloud point. Now I think it's clear what we support and what we don't. Really appreciate the quick change here!

@mirnawong1
Copy link
Contributor Author

Awesome, thank you! I setup PLs on the dbt side, and when I read our docs I was confused about this cross cloud point. Now I think it's clear what we support and what we don't. Really appreciate the quick change here!

oh that's so cool and great to know! thank you for confirming and for your huge help!

@mirnawong1 mirnawong1 merged commit 2254eba into current Oct 28, 2024
11 checks passed
@mirnawong1 mirnawong1 deleted the cross-cloud-privatelink branch October 28, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants