Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch 10 #6368

Merged
merged 10 commits into from
Oct 31, 2024
Merged

Patch 10 #6368

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a5a0114
Create databricks-changes.md
benc-db Oct 25, 2024
b666c11
Update adapter-behavior-changes.md
benc-db Oct 25, 2024
8d56f20
Update sidebars.js
benc-db Oct 25, 2024
199032c
Merge branch 'current' into patch-10
runleonarun Oct 28, 2024
769252b
Update website/docs/reference/global-configs/databricks-changes.md
benc-db Oct 29, 2024
68aa098
Update website/docs/reference/global-configs/databricks-changes.md
benc-db Oct 29, 2024
a868ce8
Merge branch 'current' into patch-10
amychen1776 Oct 29, 2024
603ef22
Update databricks-changes.md
matthewshaver Oct 29, 2024
abdda24
Update website/docs/reference/global-configs/adapter-behavior-changes.md
matthewshaver Oct 29, 2024
7befd76
Merge branch 'current' into patch-10
matthewshaver Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion website/docs/reference/global-configs/adapter-behavior-changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,18 @@ Some adapters can display behavior changes when certain flags are enabled. The f

<div className="grid--3-col">

<Card
title="Databricks"
body="Behavior changes for the Databricks adapter."
link="reference/global-configs/databricks-changes"
icon="databricks"/>

</div>
matthewshaver marked this conversation as resolved.
Show resolved Hide resolved

<Card
title="Redshift"
body="Behavior changes for the Amazon Redshift adapter."
link="reference/global-configs/redshift-changes"
icon="redshift"/>

</div>
</div>
29 changes: 29 additions & 0 deletions website/docs/reference/global-configs/databricks-changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
---
title: "Databricks adapter behavior changes"
id: "databricks-changes"
sidebar: "Databricks"
---

## Behavior Changes

Here are the current [behavior change flags](/docs/reference/global-configs/behavior-changes.md#behavior-change-flags) that are specific to `dbt-databricks`:

| Flag | `dbt-databricks`: Intro | `dbt-databricks`: Maturity |
amychen1776 marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

@matthewshaver matthewshaver Oct 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amychen1776 and @benc-db If we're going to add this table, can we handle it the same as we do the Core behavior change table and include the dbt Cloud intro and maturity dates?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can take this as a follow up

| ----------------------------- | ----------------------- | -------------------------- |
| `use_info_schema_for_columns` | 1.9.0 | TBD |
| `use_user_folder_for_python` | 1.9.0 | TBD |

### Use information schema for columns

The `use_info_schema_for_columns` flag is `False` by default.
Setting this flag to `True` will use `information_schema`, rather than `describe extended`, to get column metadata for Unity Catalog tables.
This setting is to avoid issues where `describe extended` truncates type information when the type is a complex struct;
however, this setting is not ready to be default behavior, as in order to ensure that `information_schema` is complete, we must run `REPAIR TABLE {{relation}} SYNC METADATA` prior to querying, which adds overhead.
This flag cannot be considered for maturity until we no longer need to add this overhead to every incremental materialization.
benc-db marked this conversation as resolved.
Show resolved Hide resolved

### Use user's folder for Python model notebooks

The `use_user_folder_for_python` flag is `False` by default, and results in writing uploaded python model notebooks to `/Shared/dbt_python_models/{{schema}}/`.
Setting this flag to `True` will instead write notebooks to `/Users/{{current user}}/{{catalog}}/{{schema}}/`
Writing to the `Shared` folder is being deprecated by Databricks as not following governance best practices.
benc-db marked this conversation as resolved.
Show resolved Hide resolved
We plan to promote this flag to maturity in 1.10.0.
1 change: 1 addition & 0 deletions website/sidebars.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1104,6 +1104,7 @@ const sidebarSettings = {
link: { type: "doc", id: "reference/global-configs/adapter-behavior-changes" },
items: [
"reference/global-configs/adapter-behavior-changes",
"reference/global-configs/databricks-changes",
"reference/global-configs/redshift-changes",
],
},
Expand Down
Loading