Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nfiann-bigquery-cloud-config #6336

Merged
merged 129 commits into from
Oct 28, 2024
Merged

Nfiann-bigquery-cloud-config #6336

merged 129 commits into from
Oct 28, 2024
+127 −3

Conversation

nataliefiann
Copy link
Contributor

@nataliefiann nataliefiann commented Oct 22, 2024 •
edited by github-actions bot
Loading

I have created this PR following this request / post from support: https://dbt-labs.slack.com/archives/C02NCQ9483C/p1729501766981289 to add optional configs for dbt Cloud BQ

What are you changing in this pull request and why?

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

🚀 Deployment available! Here are the direct links to the updated files:

@nataliefiann nataliefiann requested a review from a team as a code owner October 22, 2024 10:21
@vercel Vercel
Copy link

vercel bot commented Oct 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 28, 2024 4:41pm

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address labels Oct 22, 2024
mirnawong1
mirnawong1 requested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @nataliefiann , good first start at this! i think there are some areas that need more touch ups:

  • sugg having a table to convey this info, along with value type (string, integer, etc.), and examples)
  • confirm if priority supports another value (continuous query job) and whether we want to update the doc
  • share confirmation that location can be set in dbt_project.yml or models config - we don't seem to have that documented anywhere or in slack so i was surprised to see that.
  • double check if maximum bytes billed example is correct - it seems like a dbt core example

mirnawong1
mirnawong1 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for those changes and taking this on @nataliefiann ! it looks like we're there and happy to approve it!

@nataliefiann nataliefiann merged commit 42beca2 into current Oct 28, 2024
11 checks passed
@nataliefiann nataliefiann deleted the nfiann-bigquery-cloud-config branch October 28, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nataliefiann @mirnawong1