Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration caveats section to unit-tests.md #6330

Open
wants to merge 2 commits into
base: current
Choose a base branch
from

Conversation

jairus-m
Copy link

@jairus-m jairus-m commented Oct 21, 2024

Proposing the addition of a small section on "Caveats to unit test configuration" that highlights proper configuration of mock inputs for data that isn't part of the core unit test logic.

What are you changing in this pull request and why?

  • A write-up with more detail (which also catalysed this proposal) can be found here.

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Proposing the addition of a small section on "Caveats to unit test configuration" that highlights proper configuration of mock inputs for data that aren't part of the core unit test logic.

A write-up with more detail (which also catalysed this proposal) can be found [here](https://medium.com/p/e9639b51648f).
@jairus-m jairus-m requested a review from a team as a code owner October 21, 2024 21:04
Copy link

welcome bot commented Oct 21, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Oct 21, 2024

@jairus-m is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the content Improvements or additions to content label Oct 21, 2024
@runleonarun runleonarun added the new contributor Label for first-time contributors label Oct 21, 2024
@github-actions github-actions bot added the size: medium This change will take up to a week to address label Oct 21, 2024
@jairus-m jairus-m mentioned this pull request Oct 23, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants