Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose an update to data-tests.md #5607

Merged
merged 10 commits into from
Jun 18, 2024
Merged

Conversation

siljamardla
Copy link
Contributor

As surprised as I am, I could not find how to add documentation to tests.

I would assume it would look like this:

tests:
  - name: some_test_name
    description: >
      Description of the some_test_name test.
    meta:
      owner: '@firstname.lastname'

but I could not get the description to show up in the automatically generated dbt docs.

As surprised as I am, I could not find how to add documentation to tests. 

I would assume it would look like this:

```
tests:
  - name: some_test_name
    description: >
      Description of the some_test_name test.
    meta:
      owner: '@firstname.lastname'
```

but I could not get the description to show up in the automatically generated dbt docs.
@siljamardla siljamardla requested a review from a team as a code owner June 5, 2024 11:08
Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 8:41am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jun 5, 2024
@mirnawong1
Copy link
Contributor

hey @siljamardla , thanks for opening this pr up! i'm working with the team internally to chat about this further. will revert back!

Copy link

vercel bot commented Jun 18, 2024

@mirnawong1 is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @siljamardla , thanks so much for opening this pr up and great question! currently, you can’t document your data tests and we have an open issue in dbt core that requests this as well! this is something we want to support eventually but haven’t been able to prioritize yet.

I did add some clarifying language in one of the faqs and linked that faq to data-test page. I'll go ahead and merge this so we can ship something clearer - thank you for opening this up!

https://github.com/dbt-labs/docs.getdbt.com/pull/5607/files#diff-3e54ea3c7d06436f27cd022d93dd33a81afccaa1f10fd6e8f2bb51655679258fR18

@mirnawong1 mirnawong1 enabled auto-merge (squash) June 18, 2024 08:21
@mirnawong1 mirnawong1 merged commit 498fbc6 into dbt-labs:current Jun 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants