Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dc jc/update mesh guide #5600

Merged
merged 20 commits into from
Jun 17, 2024
Merged

Dc jc/update mesh guide #5600

merged 20 commits into from
Jun 17, 2024

Conversation

dave-connors-3
Copy link
Contributor

@dave-connors-3 dave-connors-3 commented Jun 4, 2024 •
edited
Loading

What are you changing in this pull request and why?

This PR adds additional mesh content to the mesh best practice guide

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

@vercel Vercel
Copy link

vercel bot commented Jun 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 3:44pm

@github-actions github-actions bot added size: medium This change will take up to a week to address content Improvements or additions to content and removed size: medium This change will take up to a week to address labels Jun 4, 2024
@dave-connors-3 dave-connors-3 marked this pull request as ready for review June 4, 2024 14:28
@dave-connors-3 dave-connors-3 requested a review from a team as a code owner June 4, 2024 14:28
matthewshaver
matthewshaver approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@matthewshaver matthewshaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dave-connors-3 Looks good from my side. Approved from the docs team, can be merged when you're ready

gwenwindflower
gwenwindflower approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@gwenwindflower gwenwindflower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome additions!

jtcohen6
jtcohen6 reviewed Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big freaking deal 🦞

thanks for the help making it that much better, clearer, mesh-ier

website/docs/best-practices/how-we-mesh/mesh-2-who-is-dbt-mesh-for.md Outdated Show resolved Hide resolved
website/docs/best-practices/how-we-mesh/mesh-2-who-is-dbt-mesh-for.md Show resolved Hide resolved
website/docs/best-practices/how-we-mesh/mesh-2-who-is-dbt-mesh-for.md Outdated Show resolved Hide resolved
website/docs/best-practices/how-we-mesh/mesh-2-who-is-dbt-mesh-for.md Outdated Show resolved Hide resolved
website/docs/best-practices/how-we-mesh/mesh-2-who-is-dbt-mesh-for.md Outdated Show resolved Hide resolved
website/docs/best-practices/how-we-mesh/mesh-2-who-is-dbt-mesh-for.md Outdated Show resolved Hide resolved
website/docs/best-practices/how-we-mesh/mesh-2-who-is-dbt-mesh-for.md Outdated Show resolved Hide resolved
website/docs/best-practices/how-we-mesh/mesh-3-structures.md
Like resource dependencies, project dependencies are acyclic, meaning they only move in one direction. This prevents `ref` cycles (or loops), which lead to issues with your data workflows. For example, if project B depends on project A, a new model in project A could not import and use a public model from project B. Refer to [Project dependencies](/docs/collaborate/govern/project-dependencies#how-to-write-cross-project-ref) for more information.

:::note
This requirement is likely to change in the future, so stay tuned for updates!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

website/docs/best-practices/how-we-mesh/mesh-3-structures.md
## Determine your git strategy

A multi-project architecture can exist in a single repo (monorepo) or as multiple projects, with each one being in their own repository (multi-repo).

- If you're a **smaller team** looking primarily to speed up and simplify development, a **monorepo** is likely the right choice, but can become unwieldy as the number of projects, models and contributors grow.
- If you’re a **larger team with multiple groups**, and need to decouple projects for security and enablement of different development styles and rhythms, a **multi-repo setup** is your best bet.

## Projects, splits, and teams
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good spot for this

website/docs/best-practices/how-we-mesh/mesh-4-implementation.md Outdated
1. Lack of buy-in that a dbt Mesh is the right long-term architecture
2. Lack of alignment on a well-scoped starting point

Provided you're not experiencing those blockers, you’re ready to start your migration.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's frame this as a "pre-mortem" exercise, so it doesn't sound so negative right out of the gate. "Before any sufficiently complex software refactor or migration, it's important to ask, 'Why might this not work?' The two most common reasons we've seen..."

@dave-connors-3 dave-connors-3 merged commit ff5fc2c into current Jun 17, 2024
11 checks passed
@dave-connors-3 dave-connors-3 deleted the dc-jc/update-mesh-guide branch June 17, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 jtcohen6 approved these changes

@matthewshaver matthewshaver matthewshaver approved these changes

@gwenwindflower gwenwindflower gwenwindflower approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dave-connors-3 @jtcohen6 @matthewshaver @gwenwindflower @mirnawong1