Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test mockup PR #5598

Closed
wants to merge 2 commits into from
Closed

Test mockup PR #5598

wants to merge 2 commits into from

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented Jun 3, 2024

What are you changing in this pull request and why?

PR that walks through git workflow with authoring tools

Checklist

@nghi-ly nghi-ly requested a review from a team as a code owner June 3, 2024 19:59
Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 8:07pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix. labels Jun 3, 2024
@@ -7,6 +7,10 @@ pagination_next: null

In software engineering, environments are used to enable engineers to develop and test code without impacting the users of their software. Typically, there are two types of environments in dbt:

Test mockup PR.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdfassdf

Copy link
Contributor Author

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for reviewing! left a cpl non-blocking suggs and approved. please lemme know if you have any questions about them!

@@ -7,6 +7,10 @@ pagination_next: null

In software engineering, environments are used to enable engineers to develop and test code without impacting the users of their software. Typically, there are two types of environments in dbt:

Test mockup PR.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second time

@@ -7,6 +7,10 @@ pagination_next: null

In software engineering, environments are used to enable engineers to develop and test code without impacting the users of their software. Typically, there are two types of environments in dbt:

Test mockup PR.

Second edit for mockup.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second time: another comment

Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @nghi-ly

Thanks for raising this PR. This looks great! I have no suggestions and will approve for you. Please let me know of there's anything else I can do.

Kind Regards

@nghi-ly
Copy link
Contributor Author

nghi-ly commented Jun 3, 2024

thank you so much @nataliefiann for the [mock pr] review!

@nghi-ly
Copy link
Contributor Author

nghi-ly commented Jun 3, 2024

closing as this was a mock walkthrough

@nghi-ly nghi-ly closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants