Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4 deprecation from docs #5597

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Removes v1.4 from the version dropdown
Removes info between lastVersion="1.4" blocks
Removes firstVersion="1.4" blocks but leaves content
Removes some mentions of v1.4 from places where it's not mentioning a requirement

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

@matthewshaver matthewshaver requested review from dataders and a team as code owners June 3, 2024 19:44
Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 11:53pm

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: large This change will more than a week to address and might require more than one person Docs team Authored by the Docs team @dbt Labs labels Jun 3, 2024
@matthewshaver matthewshaver changed the base branch from current to 1dot3-deprecation June 3, 2024 20:02
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! left just one nit and one question

## Python interface

:::warning
The `EVENT_HISTORY` object has been deprecated and removed in dbt Core v1.4+
The `EVENT_HISTORY` object has been deprecated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it make sense to remove this callout? it reads like a release note entry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! I'll remove it

Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@matthewshaver matthewshaver merged commit a21a50f into 1dot3-deprecation Jun 4, 2024
9 checks passed
@matthewshaver matthewshaver deleted the 1dot4-deprecation branch June 4, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs guides Knowledge best suited for Guides size: large This change will more than a week to address and might require more than one person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants