-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.4 deprecation from docs #5597
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! left just one nit and one question
## Python interface | ||
|
||
:::warning | ||
The `EVENT_HISTORY` object has been deprecated and removed in dbt Core v1.4+ | ||
The `EVENT_HISTORY` object has been deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it make sense to remove this callout? it reads like a release note entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call! I'll remove it
Co-authored-by: Ly Nguyen <[email protected]>
Removing calliout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are you changing in this pull request and why?
Removes v1.4 from the version dropdown
Removes info between lastVersion="1.4" blocks
Removes firstVersion="1.4" blocks but leaves content
Removes some mentions of v1.4 from places where it's not mentioning a requirement
Checklist
Adding or removing pages (delete if not applicable):
website/sidebars.js
website/vercel.json
npm run build
to update the links that point to deleted pages