Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for lifecycle pills in expandable component #5588

Merged
merged 7 commits into from
Jun 3, 2024

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented May 31, 2024

What are you changing in this pull request and why?

Add support for lifecycle pills in expandable component.

List of changes

Now

Screenshot 2024-05-31 at 11 45 19 AM

Update

Screenshot 2024-05-31 at 11 54 51 AM


@nghi-ly nghi-ly requested a review from a team as a code owner May 31, 2024 18:46
Copy link

vercel bot commented May 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 3:32pm

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels May 31, 2024
@nghi-ly nghi-ly requested a review from john-rock May 31, 2024 18:46
Copy link
Contributor

@john-rock john-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nghi-ly this looks great! All functionality appears to be working correctly. Nice job bringing the Lifecycle component into Expandable.

There is 1 super small styling adjustment we can make to get the pills aligned vertically with the expandable title but I'm not considering that a blocker for this PR. We can go over that adjustment in our mentorship meeting if you'd like!

Notification_Center
Notification_Center

Comment on lines 77 to 79
<span className={styles.headerText}>
{alt_header}
{alt_header}<Lifecycle status={lifecycle} />
</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@nghi-ly nghi-ly merged commit a5e5ee3 into current Jun 3, 2024
11 checks passed
@nghi-ly nghi-ly deleted the ly-docs-improve-expandable branch June 3, 2024 16:20
@nghi-ly nghi-ly mentioned this pull request Jul 11, 2024
1 task
nghi-ly added a commit that referenced this pull request Jul 12, 2024
## What are you changing in this pull request and why?

Vertically align pill with the expandable alt_header, per
#5588 (review)

## Checklist
- [x] Test changes in localhost

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants