Add support for lifecycle pills in expandable component #5588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
….getdbt.com into ly-docs-improve-expandable
john-rock
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Hey @nghi-ly this looks great! All functionality appears to be working correctly. Nice job bringing the Lifecycle component into Expandable.
There is 1 super small styling adjustment we can make to get the pills aligned vertically with the expandable title but I'm not considering that a blocker for this PR. We can go over that adjustment in our mentorship meeting if you'd like!
Comment on lines
77
to
79
| <span className={styles.headerText}> | ||
| {alt_header} | ||
| {alt_header}<Lifecycle status={lifecycle} /> | ||
| </span> |
1 task
nghi-ly
added a commit
that referenced
this pull request
Jul 12, 2024
## What are you changing in this pull request and why? Vertically align pill with the expandable alt_header, per #5588 (review) ## Checklist - [x] Test changes in localhost Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
Add support for lifecycle pills in expandable component.
List of changes
previewvspublic previewto align with latest definitions on our product lifecycle page https://docs.getdbt.com/docs/dbt-versions/product-lifecyclesNow
Update