Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust wildcard redirect #5579

Merged
merged 2 commits into from
May 29, 2024
Merged

Adjust wildcard redirect #5579

merged 2 commits into from
May 29, 2024

Conversation

JKarlavige
Copy link
Collaborator

@JKarlavige JKarlavige commented May 29, 2024

What are you changing in this pull request and why?

On the live site, the following URL does not redirect to the correct location, causing a 404:
https://docs.getdbt.com/docs/building-a-dbt-project/building-models/configuring-incremental-models#configuring-incremental-strategy

This was due to the wildcard redirect match kicking in (on line 1455) before the actual redirect needed (on line 1500).

This moves the wildcard match to the end of the file, to allow any other redirects to kick in first if a match is found. With this preview, the same URL should now redirect:
https://docs-getdbt-com-git-update-redirects-dbt-labs.vercel.app/docs/building-a-dbt-project/building-models/configuring-incremental-models#configuring-incremental-strategy

@JKarlavige JKarlavige requested a review from a team as a code owner May 29, 2024 16:18
Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 4:23pm

@JKarlavige JKarlavige changed the title Update redirects Adjust wildcard redirect May 29, 2024
@github-actions github-actions bot added the size: small This change will take 1 to 2 days to address label May 29, 2024
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@JKarlavige JKarlavige merged commit 0a0ca95 into current May 29, 2024
15 checks passed
@JKarlavige JKarlavige deleted the update-redirects branch May 29, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants