Adjust wildcard redirect #5579
Merged
Adjust wildcard redirect #5579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
size: small
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
On the live site, the following URL does not redirect to the correct location, causing a 404:
https://docs.getdbt.com/docs/building-a-dbt-project/building-models/configuring-incremental-models#configuring-incremental-strategy
This was due to the wildcard redirect match kicking in (on line 1455) before the actual redirect needed (on line 1500).
This moves the wildcard match to the end of the file, to allow any other redirects to kick in first if a match is found. With this preview, the same URL should now redirect:
https://docs-getdbt-com-git-update-redirects-dbt-labs.vercel.app/docs/building-a-dbt-project/building-models/configuring-incremental-models#configuring-incremental-strategy