-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/update links to dbt learn #5549
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thanks @coapacetic this looks great and the links word for me in the staging link ❓ i think it might also be beneficial to add a redirect here: https://github.com/dbt-labs/docs.getdbt.com/blob/current/website/vercel.json as well. however, i believe we have reached our limit on adding redirects. i don't want to block this pr but wanted to flag this in case we can also raise that in a related ticket since you're working with the web team on this. cc @runleonarun @matthewshaver @nghi-ly also separately, i believe the SL tableau integration is ga now so this course page might need the 'beta' removed. |
Thanks @mirnawong1 -- appreciate the super quick review! 🙌 re: Tableau BETA course -- great catch, I'll loop in @MichelleBaird-DBT to tackle that one. re: redirects, I'll yield to the docs / web team on this one with the deeper understanding of how we use redirects. related: I'll make sure we sync with Joey on migration tactics here so we merge this at the right time. 🚀 |
you got it! will revert back! |
@coapacetic i'll ask the web team and can you let us now when you'd like this merged? thank you! |
@mirnawong1 sounds great on the redirects -- I'll swing back here on when we actually hit the merge button. Also tagged you in a slack thread for viz |
@coapacetic My recommendation here is to manually change the links within the content instead of using the redirect file while we figure out how to clean that one up and make it more efficient. This work will likely take a few weeks and I don't want to block your LMS work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 hey @coapacetic , approving this pr for you and the team to merge when you and @joeygaultdbt chat about the timeline
Training changes
website/docs/guides/productionize-your-dbt-databricks-project.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final review for copy and links
heya @dbt-labs/product-docs team -- can I request one more 👍 on this after verifying links and making quick copy changes? then we can merge away! thank you! |
What are you changing in this pull request and why?
The training and web team recently launched the new LMS platform over at learn.getdbt.com. This is a PR to start the process of updating all of the courses.getdbt.com/ links to learn.getdbt.com.
Checklist