Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update links to dbt learn #5549

Merged
merged 29 commits into from
Jun 4, 2024
Merged

Conversation

coapacetic
Copy link
Contributor

@coapacetic coapacetic commented May 22, 2024

What are you changing in this pull request and why?

The training and web team recently launched the new LMS platform over at learn.getdbt.com. This is a PR to start the process of updating all of the courses.getdbt.com/ links to learn.getdbt.com.

Checklist

@coapacetic coapacetic requested a review from a team as a code owner May 22, 2024 19:57
Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 0:02am

@github-actions github-actions bot added content Improvements or additions to content developer blog This content fits on the developer blog. guides Knowledge best suited for Guides size: medium This change will take up to a week to address labels May 22, 2024
@mirnawong1
Copy link
Contributor

thanks @coapacetic this looks great and the links word for me in the staging link

❓ i think it might also be beneficial to add a redirect here: https://github.com/dbt-labs/docs.getdbt.com/blob/current/website/vercel.json as well. however, i believe we have reached our limit on adding redirects. i don't want to block this pr but wanted to flag this in case we can also raise that in a related ticket since you're working with the web team on this. cc @runleonarun @matthewshaver @nghi-ly

also separately, i believe the SL tableau integration is ga now so this course page might need the 'beta' removed.
Screenshot 2024-05-23 at 11 15 41

@coapacetic
Copy link
Contributor Author

Thanks @mirnawong1 -- appreciate the super quick review! 🙌

re: Tableau BETA course -- great catch, I'll loop in @MichelleBaird-DBT to tackle that one.

re: redirects, I'll yield to the docs / web team on this one with the deeper understanding of how we use redirects.

related: I'll make sure we sync with Joey on migration tactics here so we merge this at the right time.

🚀

@mirnawong1
Copy link
Contributor

you got it! will revert back!

@mirnawong1
Copy link
Contributor

@coapacetic i'll ask the web team and can you let us now when you'd like this merged? thank you!

@coapacetic
Copy link
Contributor Author

@mirnawong1 sounds great on the redirects -- I'll swing back here on when we actually hit the merge button. Also tagged you in a slack thread for viz

@joeygaultdbt
Copy link
Collaborator

@coapacetic My recommendation here is to manually change the links within the content instead of using the redirect file while we figure out how to clean that one up and make it more efficient. This work will likely take a few weeks and I don't want to block your LMS work.

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 hey @coapacetic , approving this pr for you and the team to merge when you and @joeygaultdbt chat about the timeline

Copy link
Contributor Author

@coapacetic coapacetic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final review for copy and links

website/docs/guides/snowflake-qs.md Outdated Show resolved Hide resolved
website/docs/guides/starburst-galaxy-qs.md Outdated Show resolved Hide resolved
@coapacetic
Copy link
Contributor Author

heya @dbt-labs/product-docs team -- can I request one more 👍 on this after verifying links and making quick copy changes?

then we can merge away! thank you!

@runleonarun runleonarun merged commit f4fd121 into current Jun 4, 2024
11 checks passed
@runleonarun runleonarun deleted the fix/update-links-to-dbt-learn branch June 4, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content developer blog This content fits on the developer blog. guides Knowledge best suited for Guides size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants