Redshift unit test limitation #5508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
runleonarun
requested changes
May 14, 2024
There was a problem hiding this comment.
@matthewshaver Just have some suggestion to smooth this message out.
| ); | ||
|
|
||
| ``` | ||
| This results in the error: |
There was a problem hiding this comment.
Suggested change
| This results in the error: | |
| The previous code results in the error: |
There was a problem hiding this comment.
Could going from "The following query" to the code example, to "the previous code" be a little redundant?
There was a problem hiding this comment.
@matthewshaver how about "This query results in the error:"
There was a problem hiding this comment.
Works for me!
Co-authored-by: Leona B. Campbell <[email protected]>
Co-authored-by: Leona B. Campbell <[email protected]>
runleonarun
reviewed
May 15, 2024
|
|
||
| ## Unit test limitations | ||
|
|
||
| Redshift doesn't support Unit tests when the SQL in the common table expression (CTE) contains functions such as `LISTAGG`, `MEDIAN`, `PERCENTILE_CONT`, etc. These functions must be executed against a user-created table. dbt combines given rows to be part of the CTE, which Redshift does not support. |
There was a problem hiding this comment.
@matthewshaver What I like about how the content is framed below is that it's clearer than this paragraph and it's framed in the positive. I think we should rewrite this paragraph so we:
- Communicate that unit test are limited by actually saying what they need to do to get unblocked. like "Avoid using SQL in CTE functions such as.." and "Unit tests can be used when you.."
- Explain how to overcome this limitation. Instead of the passive language of "These functions must be executed..." Use more active language like "Execute these functions against..."
matthewshaver
commented
May 15, 2024
matthewshaver
commented
May 15, 2024
matthewshaver
commented
May 15, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
Closes: #5430
Checklist
Adding or removing pages (delete if not applicable):
website/sidebars.jswebsite/vercel.jsonnpm run buildto update the links that point to deleted pages