Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combine and simplify sq and exports #5470

Merged
merged 43 commits into from
May 16, 2024
Merged

combine and simplify sq and exports #5470

merged 43 commits into from
May 16, 2024

Conversation

mirnawong1
Copy link
Contributor

this pr consolidates the saved queries and exports docs so its clearer how both work together. it also removes the comparison table and adds a 'configure exports' section in teh saved queries page, making sure they flow correctly.

notion project

@mirnawong1 mirnawong1 requested a review from a team as a code owner May 8, 2024 15:03
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 9:18am

@github-actions github-actions bot added content Improvements or additions to content size: large This change will more than a week to address and might require more than one person Docs team Authored by the Docs team @dbt Labs labels May 8, 2024
@@ -36,19 +84,19 @@ saved_queries:
cache:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add file name semantic model


## Configure saved query

Use saved queries to define and manage common Semantic Layer queries in YAML, including metrics and dimensions. Saved queries enable you to organize and reuse common MetricFlow queries within dbt projects. For example, you can group related metrics together for better organization, and include commonly used dimensions and filters.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include dbt_project.yml config (saved-queries) blurb

website/docs/docs/build/saved-queries.md Show resolved Hide resolved
Copy link
Contributor

@Jstein77 Jstein77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a few comments.

| `description` | String | Required | A description of the saved query. |
| `label` | String | Required | The display name for your saved query. This value will be shown in downstream tools. |
| `config` | String | Required | A config section for any parameters specifying the saved query. |
| `config::cache` | String | Optional | A boolean to specify if a saved query should be used to populate the cache. Accepts `true` or `false`. Defaults to `false` |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this really required or optional? m

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jordan confirmed it's optional

@mirnawong1 mirnawong1 enabled auto-merge May 16, 2024 09:09
@mirnawong1 mirnawong1 merged commit f4be93b into current May 16, 2024
11 checks passed
@mirnawong1 mirnawong1 deleted the combine-sq-exports branch May 16, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: large This change will more than a week to address and might require more than one person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants