Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zapier-style link markdown #5425

Merged
merged 2 commits into from
May 2, 2024
Merged

Conversation

enkeboll
Copy link
Contributor

@enkeboll enkeboll commented May 1, 2024

What are you changing in this pull request and why?

This example code seems to want to embed a hyperlink using standard Slack-supported markdown, but apparently Zapier markdown is slightly different.

This is what it looked like before:
image

And with this change:
image

Checklist

@enkeboll enkeboll requested a review from a team as a code owner May 1, 2024 18:29
Copy link

welcome bot commented May 1, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 2:59pm

@runleonarun runleonarun added the new contributor Label for first-time contributors label May 1, 2024
@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: x-small This change will take under 3 hours to fix. labels May 1, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch, thanks so much @enkeboll ! appreciate you opening this pr up to fix this - looking forward to future contributions ✨

@mirnawong1 mirnawong1 enabled auto-merge May 2, 2024 14:52
@mirnawong1 mirnawong1 merged commit 4d96040 into dbt-labs:current May 2, 2024
4 checks passed
@enkeboll enkeboll deleted the patch-1 branch May 2, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content guides Knowledge best suited for Guides new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants