Update import-a-project-by-git-url.md #5419
Conversation
adding an optional step 5, as when customers (and myself) import codecommit repo via git url, the PR URL field did not auto populate. It was an added manual step that needed to be done. (I am not sure how to place the image in the center, sorry!)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
|
hey @wusanny thanks so much for opening this! happy to take a look and posting some of the questions i had here as well:
|
| - Replace `<repo>` with the name of your repository (note that it is case sensitive). | ||
| <Lightbox src="/img/docs/collaborate/pr-template-example.jpg" width="60%" title="Configure PR Template URLs" /> | ||
| - Replace `<repo>` with the name of your repository (note that it is case sensitive). | ||
| - Click **Save**. |
There was a problem hiding this comment.
@wusanny do users have to refresh the ide? i think so, yea?
| - In the **Pull request URL** field, set the URL based on the suggested [PR template format](/docs/collaborate/git/pr-template#aws-codecommit). | ||
| - Replace `<repo>` with the name of your repository (note that it is case sensitive). | ||
| <Lightbox src="/img/docs/collaborate/pr-template-example.jpg" width="60%" title="Configure PR Template URLs" /> | ||
| - Replace `<repo>` with the name of your repository (note that it is case sensitive). |
There was a problem hiding this comment.
love this - thanks for adding that detail about case sensitive!
There was a problem hiding this comment.
great job @wusanny ! love this contribution and it's super clear! I'm going to go ahead and approve this for you, however i do wonder if we should raise this with product or check if this is expected behavior? this sounds like a workaround - so shouldn't the template be automatically filled out? we don't really want users merging code changes directly to the default branch.
so i made some tweaks to the pr and they include, let me know what you think!:
- bolding the dbt cloud UI elements/pages
- adding the images to the
imgfolder. - breaking down the steps further
|
as an update, @wusanny has tested this and we've raised this to product. refer to slack thread here: https://dbt-labs.slack.com/archives/CSSHB76QL/p1717147442123369?thread_ts=1714581453.391999&cid=CSSHB76QL to see how the convo goes and whether we want to add this to the doc itself or clarify the behavior. |
There was a problem hiding this comment.
confirmed this is a feature request, not a bug. clarifying further and approving/merging for @wusanny
What are you changing in this pull request and why?
Adding an optional step 5 under AWS CodeCommit.
When customers (and myself) import CodeCommit repo via Git URL, the PR URL field did not auto populate. As such in the IDE, we were prompted to merge directly to primary branch. We needed to add the URL manually.
It is a common and good practice to open a PR for code changes to be reviewed before merging them into default branch. Since importing via Git URL for CodeCommit does not auto-populate the field, it would be good if we can give a heads up to our customers about it.
Checklist
Adding or removing pages (delete if not applicable):
website/sidebars.jswebsite/vercel.jsonnpm run buildto update the links that point to deleted pages