-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gsheets.md #5378
Update gsheets.md #5378
Conversation
Google Sheets updates
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
making some updates based on the functionality
few additional updates
a few more edits!
remove from card
@@ -1,8 +1,8 @@ | |||
--- | |||
title: "Google Sheets (beta)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
--- | ||
|
||
# Google Sheets <Lifecycle status='preview'/> | ||
|
||
:::info Preview functionality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:::info Preview functionality | |
:::info Preview functionality |
--- | ||
|
||
# Google Sheets <Lifecycle status='preview'/> | ||
|
||
:::info Preview functionality | ||
Google Sheets integration with the dbt Semantic Layer is a [Preview](/docs/dbt-versions/product-lifecycles#dbt-cloud) feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should prob remove this callout too right @rpourzand ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! good call
@@ -11,7 +11,7 @@ The following tools integrate with the dbt Semantic Layer: | |||
icon="tableau-software"/> | |||
|
|||
<Card | |||
title="Google Sheets (Preview)" | |||
title="Google Sheets" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the 'preview' mention from the main avail integrations card parge too @rpourzand
- For categorical dimensions, you can type a value into search or select from a populated list. For entities, you must type the value you are looking for as we do not load all of them given the large number of values. | ||
- Continue adding additional filters as needed with AND and OR. | ||
|
||
For time dimensions, you can use the time range selector to filter on the primary time dimension with preset or custom options. For non-primary time dimensions, use the "Where" option to apply filters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By non-primary time dimensions
, do you mean non-metric time dimensions? The time range only works for metric time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i changed it and i think the original was '...to filter on time dimensions that are not the primary time series for the metrics.' maybe i should add 'series for metrics' at the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. Anything that's not metric_time!
- For categorical dimensions, you can type a value into search or select from a populated list. For entities, you must type the value you are looking for as we do not load all of them given the large number of values. | ||
- Continue adding additional filters as needed with AND and OR. | ||
|
||
For time dimensions, you can use the time range selector to filter on the primary time dimension with preset or custom options. For non-primary time dimensions, use the "Where" option to apply filters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it sounds a little awkward so am going to wait for @rpourzand
For time dimensions, you can use the time range selector to filter on the primary time dimension with preset or custom options. For non-primary time dimensions, use the "Where" option to apply filters. | |
For time dimensions, you can use the time range selector to filter on the primary time dimension with preset or custom options. For non-primary time dimension series for metrics, use the "Where" option to apply filters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we say 'For non-metric time dimensions, use the "where"...'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I tweaked a bit! let me know your thoughts
made some tweaks to this time description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! do you want me to merge @rpourzand @DevonFulcher or hang tight?
@mirnawong1 let's wait a bit to launch. We're still fixing some bugs. I'll give you the go ahead |
final change.
@mirnawong1 this can be released first thing tomorrow! |
Google Sheets updates
Merge status: Do not merge this PR. Waiting on PM to give merge go ahead as they're still working through things. ✅ PM approved and ok to merge
What are you changing in this pull request and why?
Checklist
Adding or removing pages (delete if not applicable):
website/sidebars.js
website/vercel.json
npm run build
to update the links that point to deleted pages