Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gsheets.md #5378

Merged
merged 19 commits into from
May 3, 2024
Merged

Conversation

rpourzand
Copy link
Contributor

@rpourzand rpourzand commented Apr 26, 2024

Google Sheets updates

Merge status: Do not merge this PR. Waiting on PM to give merge go ahead as they're still working through things. ✅ PM approved and ok to merge

What are you changing in this pull request and why?

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

Google Sheets updates
@rpourzand rpourzand requested a review from a team as a code owner April 26, 2024 18:15
Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 10:27am

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Apr 26, 2024
making some updates based on the functionality
few additional updates
a few more edits!
@@ -1,8 +1,8 @@
---
title: "Google Sheets (beta)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

---

# Google Sheets <Lifecycle status='preview'/>

:::info Preview functionality
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:::info Preview functionality
:::info Preview functionality

---

# Google Sheets <Lifecycle status='preview'/>

:::info Preview functionality
Google Sheets integration with the dbt Semantic Layer is a [Preview](/docs/dbt-versions/product-lifecycles#dbt-cloud) feature.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should prob remove this callout too right @rpourzand ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! good call

@@ -11,7 +11,7 @@ The following tools integrate with the dbt Semantic Layer:
icon="tableau-software"/>

<Card
title="Google Sheets (Preview)"
title="Google Sheets"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the 'preview' mention from the main avail integrations card parge too @rpourzand

Screenshot 2024-04-29 at 17 05 31

- For categorical dimensions, you can type a value into search or select from a populated list. For entities, you must type the value you are looking for as we do not load all of them given the large number of values.
- Continue adding additional filters as needed with AND and OR.

For time dimensions, you can use the time range selector to filter on the primary time dimension with preset or custom options. For non-primary time dimensions, use the "Where" option to apply filters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By non-primary time dimensions, do you mean non-metric time dimensions? The time range only works for metric time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i changed it and i think the original was '...to filter on time dimensions that are not the primary time series for the metrics.' maybe i should add 'series for metrics' at the end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Anything that's not metric_time!

- For categorical dimensions, you can type a value into search or select from a populated list. For entities, you must type the value you are looking for as we do not load all of them given the large number of values.
- Continue adding additional filters as needed with AND and OR.

For time dimensions, you can use the time range selector to filter on the primary time dimension with preset or custom options. For non-primary time dimensions, use the "Where" option to apply filters.
Copy link
Contributor

@mirnawong1 mirnawong1 Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it sounds a little awkward so am going to wait for @rpourzand

Suggested change
For time dimensions, you can use the time range selector to filter on the primary time dimension with preset or custom options. For non-primary time dimensions, use the "Where" option to apply filters.
For time dimensions, you can use the time range selector to filter on the primary time dimension with preset or custom options. For non-primary time dimension series for metrics, use the "Where" option to apply filters.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we say 'For non-metric time dimensions, use the "where"...'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I tweaked a bit! let me know your thoughts

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! do you want me to merge @rpourzand @DevonFulcher or hang tight?

@rpourzand
Copy link
Contributor Author

@mirnawong1 let's wait a bit to launch. We're still fixing some bugs. I'll give you the go ahead

@mirnawong1 mirnawong1 changed the title Update gsheets.md DO NOT MERGE - Update gsheets.md Apr 29, 2024
final change.
@rpourzand
Copy link
Contributor Author

@mirnawong1 this can be released first thing tomorrow!

@mirnawong1 mirnawong1 merged commit b680b74 into current May 3, 2024
11 checks passed
@mirnawong1 mirnawong1 deleted the rpourzand-sheets-final-touches-milestone-update branch May 3, 2024 10:45
@mirnawong1 mirnawong1 changed the title DO NOT MERGE - Update gsheets.md Update gsheets.md May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants