Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-functional example command and fix other one #5272

Merged
merged 7 commits into from
Apr 16, 2024
Merged

Remove non-functional example command and fix other one #5272

merged 7 commits into from
Apr 16, 2024

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Apr 11, 2024 •
edited
Loading

Preview

What are you changing in this pull request and why?

Noticed a couple code examples that won't work as-is, so fixed them by removing:

  • double quotes surrounding all the CLI flags
  • --defer flag for ls command

Checklist

@vercel Vercel
Copy link

vercel bot commented Apr 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 1:57pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Apr 11, 2024
@dbeatty10 dbeatty10 marked this pull request as ready for review April 11, 2024 23:56
@dbeatty10 dbeatty10 requested a review from a team as a code owner April 11, 2024 23:56
@dbeatty10 dbeatty10 enabled auto-merge (squash) April 12, 2024 17:34
@mirnawong1
Copy link
Contributor

hey @dbeatty10 , thank you for creating this pr! curious why the quotes won't work. i haven't tested this myself and i'm not sure if I'm misunderstanding this correctly -- but i believe this section recommends CLI users use quotes for arguments passed to the --select or --exclude options in dbt commands, to ensure compatibility across different operating systems, terminals, and user interfaces.

the quotes were added to the docs per this issue #4040, which recommends quotes.

let me know what you think and happy to jam on this!

@dbeatty10
Copy link
Contributor Author

@mirnawong1 Good call about keeping the quotes per those resources you linked 🧠

I updated this PR via 349fbe2 so the quotes are only around the --select arguments.

mirnawong1
mirnawong1 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for clarifying @dbeatty10 ! lgtm and shipping!

@dbeatty10 dbeatty10 merged commit 01fffea into current Apr 16, 2024
11 checks passed
@dbeatty10 dbeatty10 deleted the dbeatty10-patch-1 branch April 16, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbeatty10 @mirnawong1