Update code example for fail_calc
#5221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
1 task
nghi-ly
approved these changes
Apr 3, 2024
1 task
mirnawong1
added a commit
that referenced
this pull request
Apr 9, 2024
…no rows at all (#5246) [Preview](https://docs-getdbt-com-git-dbeatty10-patch-1-dbt-labs.vercel.app/reference/resource-configs/fail_calc) ## What are you changing in this pull request and why? Follow-up to #5221 resolves #918 See also: dbt-labs/dbt-core#4248 ## Checklist - [x] Review the [Content style guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md) so my content adheres to these guidelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
What are you changing in this pull request and why?
The current code example does not always work and may raise an error like this:
As described in dbt-labs/dbt-core#4248, it's known that:
fail_calcis a sum() function raises an error when the test produces no rows at allWell, that explains why the code example doesn't work!
Jerco described two options for dealing with this:
fail_calc, to handle the case in which no rows are returnedThis PR adopts the 2nd option and updates the code example to handle the case in which no rows are returned.
Checklist