Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting custom materializations #5211

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Documenting custom materializations #5211

merged 3 commits into from
Apr 4, 2024

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Apr 2, 2024

Preview

What are you changing in this pull request and why?

dbt-labs/dbt-core#9841 asked about documenting custom materializations, and this PR explains how to document the macro(s) associated with each custom materialization.

Checklist

  • Review the Content style guide so my content adheres to these guidelines.
  • I tested that the code example works

Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 9:09am

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Apr 2, 2024
@dbeatty10 dbeatty10 marked this pull request as ready for review April 2, 2024 16:05
@dbeatty10 dbeatty10 requested a review from a team as a code owner April 2, 2024 16:05
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and small tweak. thank you so much @dbeatty10 !

@mirnawong1 mirnawong1 merged commit 5f37685 into current Apr 4, 2024
11 checks passed
@mirnawong1 mirnawong1 deleted the dbeatty10-patch-1 branch April 4, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants